<img alt="Liferay" height="36" src="http://cdn.www.liferay.com/osb-www-theme/images/custom/heading.png" width="146" />

Rank: Liferay Legend

Posts: 4496

Join Date: September 1, 2006

I have a fix for http://issues.liferay.com/browse/LPS-3800 for Liferay 6.1. Since no work has been done to resolve it, I'm posting here to see if there is interest in committing my fix for 6.1.

Basically, in com.liferay.portal.struts.PortalRequestProcessor.processPath() the theme display must be checked to see if the user is being impersonated, and does not redirect to the terms of use, current password check, valid email address check, or password reminders pages.

If there is interest, I'll get my patch together and submit it...

RE: Impersonating New User should not bring up Terms Of Use...

June 5, 2012 11:07 AM

Answer

Sampsa Sohlman

LIFERAY STAFF

Rank: Regular Member

Posts: 183

Join Date: September 27, 2007

I'm usually disabling that feature, but it should not be there, if someone is impersonating user.

I vote for it.

- Sampsa

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 5, 2012 12:33 PM

Answer

Rank: Liferay Legend

Posts: 4496

Join Date: September 1, 2006

Snap! Brian Chan beat me to it in February... emoticon

It's in the trunk now, so I'm guessing it will be part of GA2...

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 30, 2012 9:32 AM

Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 8000

Join Date: March 23, 2010

I just check the LPS in the first post and it seems to have been fixed by Douglas and should have been fixed in 6.0.0 preview?
If it's not working in 6.1.0 CE, it's probably wasn't fixed properly. :-)

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 30, 2012 9:47 AM

Answer

Rank: Liferay Legend

Posts: 4496

Join Date: September 1, 2006

Well, it's definitely broken in 6.0 EE SP2. I was going to submit a fix but once I started checking through the Git commits, I found that Brian had actually done it in February...

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 30, 2012 9:55 AM

Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 8000

Join Date: March 23, 2010

once I started checking through the Git commits, I found that Brian had actually done it in February...

Do you know to which issue Brian did a fix? Wonder what Douglas did. It may have been regressed in 6.0?

I'm beginning to think liferay's jira isn't working very well. This may be the reason why liferay's quality isn't improving too much. :-)

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 30, 2012 9:01 PM

Answer

Rank: Liferay Legend

Posts: 4496

Join Date: September 1, 2006

Not off the top of my head, although it should be easy to find. Using the eGit plugin for Eclipse and looking at the history for the file is how I determined it was fixed in February and Brian was the committer, but I don't remember the comment that was associated w/ the change...

Mark as an Answer

RE: Impersonating New User should not bring up Terms Of Use...

June 30, 2012 9:24 PM

Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 8000

Join Date: March 23, 2010

Sorry but can't find any entries in liferay.portal.struts.PortalRequestProcessor.processPath() in Februrary authored by Brian Chan.

https://github.com/liferay/liferay-portal/commits/master/portal-impl/src/com/liferay/portal/struts/PortletRequestProcessor.java

hhuijser5 seems to have made some code formatting modifications