Combination View Flat View Tree View
Threads [ Previous | Next ]
toggle
New idea for Community Verifiers Drew Blessing August 1, 2012 5:35 PM
RE: New idea for Community Verifiers Mika Koivisto August 1, 2012 6:04 PM
RE: New idea for Community Verifiers James Falkner August 1, 2012 8:32 PM
RE: New idea for Community Verifiers Juan Fernández August 2, 2012 12:28 AM
RE: New idea for Community Verifiers Davide N. P. Rossi August 2, 2012 12:29 AM
RE: New idea for Community Verifiers Alan Wamser August 2, 2012 8:21 AM
RE: New idea for Community Verifiers Drew Blessing August 2, 2012 6:23 PM
RE: New idea for Community Verifiers Juan Fernández August 2, 2012 11:38 PM
RE: New idea for Community Verifiers Drew Blessing August 3, 2012 6:18 AM
RE: New idea for Community Verifiers Juan Fernández August 5, 2012 11:20 PM
RE: New idea for Community Verifiers Drew Blessing August 6, 2012 4:58 AM
RE: New idea for Community Verifiers Niko Humalamäki August 5, 2012 9:06 AM
RE: New idea for Community Verifiers Drew Blessing August 6, 2012 4:58 AM
RE: New idea for Community Verifiers Drew Blessing August 6, 2012 9:07 PM
RE: New idea for Community Verifiers James Falkner August 7, 2012 9:25 AM
RE: New idea for Community Verifiers Juan Fernández August 8, 2012 4:12 AM
RE: New idea for Community Verifiers James Falkner August 16, 2012 1:54 PM
RE: New idea for Community Verifiers Drew Blessing August 16, 2012 5:15 PM
RE: New idea for Community Verifiers James Falkner August 21, 2012 1:58 PM
RE: New idea for Community Verifiers Drew Blessing August 22, 2012 7:52 AM
RE: New idea for Community Verifiers Jorge Ferrer August 23, 2012 2:29 AM
RE: New idea for Community Verifiers Sampsa Sohlman August 24, 2012 12:01 AM
RE: New idea for Community Verifiers Mika Koivisto August 27, 2012 11:43 AM
RE: New idea for Community Verifiers Jorge Ferrer August 31, 2012 3:33 AM
RE: New idea for Community Verifiers Sampsa Sohlman September 3, 2012 5:45 AM
Drew Blessing
New idea for Community Verifiers
August 1, 2012 5:35 PM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

I think it would be great to get the CV team going again. Lately there has been a lot of talk about how community contributions are handled, or not handled. There seems to be a perceived disconnect between community developers and Liferay developers. So, what I propose is that the CV team works together with community developers and Liferay developers to bridge that gap and begin forming closer relationships with module owners. There are currently 71 issues marked "Contributed Solution" or "Community Resolved." This is basically the pool we would work from, or any other ticket that has a patch file attached to fix a bug, add a feature, etc. Here's what might happen...

A Community Verifier member chooses an issue. Then, attempt to verify the status of the issue. Options may include:
a. The fix/contribution is not really a fix/contribution. It is a bug report or has been fixed elsewhere. (Maybe someone accidentally tagged it as "Contributed Solution" not realizing what that really means)
b. The fix is no longer relevant - That feature or portion of the feature was deprecated.
c. The fix is relevant but was contributed prior to version 6.1. CV-er can work with the original submitter (or self) to update the fix to be compatible with 6.1. Then, work with the Liferay module owner to incorporate the fix into the 6.1.x branch.
d. The fix is good. Work with the Liferay module owner to incorporate into 6.1 or 6.2 branch as appropriate.

Also, as part of this program I hope that we can educate community developers, including ourselves. Right now developers are attaching patches to tickets, etc. Using GitHub properly drastically decreases the amount of time it takes to evaluate and integrate a contribution. For starters, I would like to update/improve the Liferay.com wiki article that shows how to contribute. Then, as we attack the issues we can work with the community developer to make sure the contribution is submitted in a way Liferay module owners can quickly address it.

I think this would be a fun/interesting way for us to get to know the Liferay module owners and really improve relationships with other community developers. Of course, we would also be improving the core product. Please let me know what you think - I'm open to comments or suggestions. Based on feedback here I will begin putting some documents together to help us through the process.
Mika Koivisto
RE: New idea for Community Verifiers
August 1, 2012 6:04 PM
Answer

Mika Koivisto

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1501

Join Date: August 7, 2006

Recent Posts

I like this idea a lot. I always thought that CV team is there to validate issues created by community and once they are verified they would actually get more attention and go into the backlog of issues we work on and that way those issues would actually be taken care of.
James Falkner
RE: New idea for Community Verifiers
August 1, 2012 8:32 PM
Answer

James Falkner

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1222

Join Date: September 17, 2010

Recent Posts

Drew Blessing:
I think it would be great to get the CV team going again. Lately there has been a lot of talk about how community contributions are handled, or not handled. There seems to be a perceived disconnect between community developers and Liferay developers. So, what I propose is that the CV team works together with community developers and Liferay developers to bridge that gap and begin forming closer relationships with module owners. There are currently 71 issues marked "Contributed Solution" or "Community Resolved." This is basically the pool we would work from, or any other ticket that has a patch file attached to fix a bug, add a feature, etc. Here's what might happen...

A Community Verifier member chooses an issue. Then, attempt to verify the status of the issue. Options may include:
a. The fix/contribution is not really a fix/contribution. It is a bug report or has been fixed elsewhere. (Maybe someone accidentally tagged it as "Contributed Solution" not realizing what that really means)
b. The fix is no longer relevant - That feature or portion of the feature was deprecated.
c. The fix is relevant but was contributed prior to version 6.1. CV-er can work with the original submitter (or self) to update the fix to be compatible with 6.1. Then, work with the Liferay module owner to incorporate the fix into the 6.1.x branch.
d. The fix is good. Work with the Liferay module owner to incorporate into 6.1 or 6.2 branch as appropriate.

Also, as part of this program I hope that we can educate community developers, including ourselves. Right now developers are attaching patches to tickets, etc. Using GitHub properly drastically decreases the amount of time it takes to evaluate and integrate a contribution. For starters, I would like to update/improve the Liferay.com wiki article that shows how to contribute. Then, as we attack the issues we can work with the community developer to make sure the contribution is submitted in a way Liferay module owners can quickly address it.

I think this would be a fun/interesting way for us to get to know the Liferay module owners and really improve relationships with other community developers. Of course, we would also be improving the core product. Please let me know what you think - I'm open to comments or suggestions. Based on feedback here I will begin putting some documents together to help us through the process.


Of course I wholeheartedly endorse this effort - I getting module owners together with interested community contributors is the best way to strengthen our community and share the knowledge that is bottled up in each of us emoticon So I can assist in putting the docs together and recruiting. It's basically free training for anyone who participates! And we get to know one another too. Perhaps we can throw a big party when we resolve, say, 80% of the outstanding contributions emoticon I'd be happy with 10-20% !
Juan Fernández
RE: New idea for Community Verifiers
August 2, 2012 12:28 AM
Answer

Juan Fernández

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1250

Join Date: October 2, 2008

Recent Posts

Yeah!!!! FINALLY!!!! Thanks a lot for bringing this up, Drew!! emoticon

I've been doing this task from time to time and it is really COSTLY to review, discuss or discard each one of the tickets opened. Many of them doesn't make sense, or are bug reports, or are just improvement proposals.. so if you guys manage to "clean" that list and report to us, the core engineers, the actual contributed solutions directly...man, that'd be AWESOME.

Last week I heard that usually in open source projects, if you don't answer contributors in less than 48 hours, you will loose them in a huge percentage of cases, so this innitiative is really important for the Liferay community.

Regarding module owners, I can review/asses/validate contributions for the following modules: blogs, wiki, calendar, wcm, polls (for the rest, you can ask me who to ask for help)

You can point developers with Git knowledge to send me PRs to https://github.com/juanferrub/liferay-portal OR just ping me when there's a patch attached to a ticket in Jira

Thanks, guys!
Davide N. P. Rossi
RE: New idea for Community Verifiers
August 2, 2012 12:29 AM
Answer

Davide N. P. Rossi

Rank: Junior Member

Posts: 55

Join Date: July 3, 2010

Recent Posts

I personally found that Community Verifier Program contributed alot to bring issues to light and was expecting it to be a long term plan. Thats why a I posed the question in another thread: Whats happened to community verifiers???

This is the reply I expected and can't wait for the program to start again.

Put me on the possible recruited list... :-)
Alan Wamser
RE: New idea for Community Verifiers
August 2, 2012 8:21 AM
Answer

Alan Wamser

Rank: Junior Member

Posts: 26

Join Date: April 15, 2010

Recent Posts

I would be interested in participating... The Wiki article would be a huge help for people that haven't had any experience with this type of team collaboration.
Drew Blessing
RE: New idea for Community Verifiers
August 2, 2012 6:23 PM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Wow. It's great to see so much interest from both sides. I will work with James to get everything ready to go. Thanks!
Juan Fernández
RE: New idea for Community Verifiers
August 2, 2012 11:38 PM
Answer

Juan Fernández

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1250

Join Date: October 2, 2008

Recent Posts

Hi Drew:
instead of writing a new wiki article, why don't we extend this one? [Contributing]
When you go to liferay.com - community - contribute it brings you to that article, so I think we should improve it A LOT.
Things we can add there:
  • Say that there are two ways: patches or GIT pull-requests
  • Link to article explaining how to get the latest code base
  • Link to article explaining how to build trunk in different IDEs
  • Link to the list of module owners, so that they know who to ping


Thanks!
Drew Blessing
RE: New idea for Community Verifiers
August 3, 2012 6:18 AM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Juan Fernández:
Hi Drew:
instead of writing a new wiki article, why don't we extend this one? [Contributing]


That's definitely a good idea! I will work with James to get this updated. You mention patches attached to tickets - are you OK with this method of contribution? I thought maybe GIT was the sole method preferred now.
Niko Humalamäki
RE: New idea for Community Verifiers
August 5, 2012 9:06 AM
Answer

Niko Humalamäki

Rank: New Member

Posts: 16

Join Date: February 21, 2012

Recent Posts

Nice, Think I'll be reading up on contributing emoticon
Juan Fernández
RE: New idea for Community Verifiers
August 5, 2012 11:20 PM
Answer

Juan Fernández

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1250

Join Date: October 2, 2008

Recent Posts

Drew Blessing:
You mention patches attached to tickets - are you OK with this method of contribution? I thought maybe GIT was the sole method preferred now.


Hi Drew:
there's a lot of svn people around in the corporate world, and for them, if you force them to use another tool, you'll make them give up in the contribution process. GitHub is INFINITELY better for us to receive contributions and we should try educate the community members in how good it is to use git and how to use git by all means we have, but I don't want to FORCE them in case they don't know about Git.

The first goal here is to increase the number of contributions to the project, to make the contribution process easier for newcomers, and with that goal in mind the Git vs Patch fight is meaningless, do you agree? After we have a good group of contributors, we can focus on increasing the "quality" of those contributors by moving them to Git

Thanks for all your efforts, Drew
Drew Blessing
RE: New idea for Community Verifiers
August 6, 2012 4:58 AM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Juan Fernández:
The first goal here is to increase the number of contributions to the project, to make the contribution process easier for newcomers, and with that goal in mind the Git vs Patch fight is meaningless, do you agree?


Yes, that sounds good. Thanks!
Drew Blessing
RE: New idea for Community Verifiers
August 6, 2012 4:58 AM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Niko H:
Nice, Think I'll be reading up on contributing emoticon


I'm glad you're interested, Niko! Let us know if you have questions about CV and contributing. We'll get this new initiative off the ground soon.
Drew Blessing
RE: New idea for Community Verifiers
August 6, 2012 9:07 PM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

I made a first attempt update to the Contributing wiki. http://www.liferay.com/community/wiki/-/wiki/Main/Contributing

There are some other things I would like to add. First, I'd like to skim some of the information from this Liferay page and add to the wiki: http://www.liferay.com/community/welcome/contribute. There's some really good stuff there. Also, I'd like to write/update a wiki page on using Git/GitHub to contribute code. There should also probably be some writing/updating of building Liferay from source, setting up Liferay IDE, etc. I know there are some of these out there but they are horribly old or slapped together with years of different information.

As we go, I'd definitely appreciate any input you guys can give on the wikis. Some of this will be perspective only and I want to make sure it's as accurate and applicable to all as possible. Thanks!

EDIT: I will also add the pieces Juan suggested above emoticon
James Falkner
RE: New idea for Community Verifiers
August 7, 2012 9:25 AM
Answer

James Falkner

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1222

Join Date: September 17, 2010

Recent Posts

Drew Blessing:
I made a first attempt update to the Contributing wiki. http://www.liferay.com/community/wiki/-/wiki/Main/Contributing

There are some other things I would like to add. First, I'd like to skim some of the information from this Liferay page and add to the wiki: http://www.liferay.com/community/welcome/contribute. There's some really good stuff there. Also, I'd like to write/update a wiki page on using Git/GitHub to contribute code. There should also probably be some writing/updating of building Liferay from source, setting up Liferay IDE, etc. I know there are some of these out there but they are horribly old or slapped together with years of different information.

As we go, I'd definitely appreciate any input you guys can give on the wikis. Some of this will be perspective only and I want to make sure it's as accurate and applicable to all as possible. Thanks!

EDIT: I will also add the pieces Juan suggested above emoticon


Drew, thanks for all your help getting the 'contributions' pages in order - it's sorely needed! And I wholeheartedly agree with Juan's sentiments re: git vs. svn vs. patch. As part of your program, I think CVers should prefer git if they know it, but not require it, when working with community contributors to get their existing contributions in order. Ultimately, any contribution will eventually need to go through git, so if that can happen earlier in the process, then great, but not if it means losing excitement and desire to participate emoticon The git/github article will help with that. Dave has some content you may borrow from, but he stopped short of explaining how to submit pull requests, etc emoticon
Juan Fernández
RE: New idea for Community Verifiers
August 8, 2012 4:12 AM
Answer

Juan Fernández

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1250

Join Date: October 2, 2008

Recent Posts

We should link this page... it' quite cool! emoticon Getting started as a Liferay Developer in a few steps
James Falkner
RE: New idea for Community Verifiers
August 16, 2012 1:54 PM
Answer

James Falkner

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1222

Join Date: September 17, 2010

Recent Posts

Juan Fernández:
We should link this page... it' quite cool! emoticon Getting started as a Liferay Developer in a few steps


Hey Drew et al,

I created this step-by-step guide for participating in this effort. Please check it out and make edits as necessary (inserting links to the git-specific pages Drew is working on). I am going to start recruiting from the existing CVers and get some new ones hopefully emoticon Cheers!
Drew Blessing
RE: New idea for Community Verifiers
August 16, 2012 5:15 PM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Thanks, James! That looks great. I'm working on the Contribute using Git and GitHub wiki. I have a ways to go but I went ahead and published the first part so anyone else can begin to look at it and suggest changes.

On a side note, I'm changing jobs next week so bear with me for a couple of weeks as I transition. Things will be crazy but I really want to get this program off the ground!
James Falkner
RE: New idea for Community Verifiers
August 21, 2012 1:58 PM
Answer

James Falkner

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1222

Join Date: September 17, 2010

Recent Posts

Drew Blessing:
Thanks, James! That looks great. I'm working on the Contribute using Git and GitHub wiki. I have a ways to go but I went ahead and published the first part so anyone else can begin to look at it and suggest changes.

On a side note, I'm changing jobs next week so bear with me for a couple of weeks as I transition. Things will be crazy but I really want to get this program off the ground!


Hey Drew, I created another wiki page to track community verifier activity. Hopefully our recruiting drive will help fill the board with our awesome community members! emoticon

Good luck in the new gig!
Drew Blessing
RE: New idea for Community Verifiers
August 22, 2012 7:52 AM
Answer

Drew Blessing

Rank: Junior Member

Posts: 79

Join Date: January 27, 2011

Recent Posts

Alright everyone. Everything is in place. If you're interested in helping out go ahead and find a ticket from this list http://issues.liferay.com/secure/Dashboard.jspa?selectPageId=13572. I think we'll find that many are easily resolved and won't take too much work.

Don't be afraid to jump in! Just use the contribution guide James created here http://www.liferay.com/community/wiki/-/wiki/Main/Contribution+Processing+for+Community+Verifiers. Post back on this forum if you need help and we'll help you out.

Thanks for your help!
Jorge Ferrer
RE: New idea for Community Verifiers
August 23, 2012 2:29 AM
Answer

Jorge Ferrer

LIFERAY STAFF

Rank: Liferay Legend

Posts: 2757

Join Date: August 31, 2006

Recent Posts

Hey Drew et al,

This is an awesome idea, thanks so much.

I had been planning to write a blog entry about our move to GitHub (which hasn't really been publicly announced) and explain how to contribute. This proposal comes just in time. I will be pointing people to the wiki pages and forum threads.

Drew, it's very encouraging to have people like you in the community emoticon
Sampsa Sohlman
RE: New idea for Community Verifiers
August 24, 2012 12:01 AM
Answer

Sampsa Sohlman

LIFERAY STAFF

Rank: Regular Member

Posts: 218

Join Date: September 27, 2007

Recent Posts

Jorge Ferrer:
I had been planning to write a blog entry about our move to GitHub


I think this would be good idea to describe your way to use git.

I have impression that Liferay way of working with git is to create branch per issue and generate pull request from resulted changes. Currently this is not described at http://www.liferay.com/community/wiki/-/wiki/Main/Contribute+using+Git+and+GitHub and would be good add on there too.
Mika Koivisto
RE: New idea for Community Verifiers
August 27, 2012 11:43 AM
Answer

Mika Koivisto

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1501

Join Date: August 7, 2006

Recent Posts

Yeah, we do create a new branch for each ticket then send it to our peer reviewer who sends it to one of the master reviewer who have push rights to the liferay git account. In a way we are all just contributors.
Jorge Ferrer
RE: New idea for Community Verifiers
August 31, 2012 3:33 AM
Answer

Jorge Ferrer

LIFERAY STAFF

Rank: Liferay Legend

Posts: 2757

Join Date: August 31, 2006

Recent Posts

As promised, I've finally been able to write the blog entry:
http://www.liferay.com/web/jorge.ferrer/blog/-/blogs/liferay-s-source-is-now-at-github-go-fork-it-

Sampsa, it's more of an announcement than an in depth description of how we use it. I'll think of writing a second blog entry about how we use GitHub later, but I'd prefer to wait until we get rid of git-svn since it limits some of the capabilities of Git. Once we stop using it we'll probably change be able to use branches even more aggressively emoticon
Sampsa Sohlman
RE: New idea for Community Verifiers
September 3, 2012 5:45 AM
Answer

Sampsa Sohlman

LIFERAY STAFF

Rank: Regular Member

Posts: 218

Join Date: September 27, 2007

Recent Posts

Jorge Ferrer:
Sampsa, it's more of an announcement than an in depth description of how we use it.


True, didn't give answers what I was looking for.

Jorge Ferrer:
I'll think of writing a second blog entry about how we use GitHub later


I might wait for this, but it might be that I learn that earlier, little bit harder way emoticon

Jorge Ferrer:
, but I'd prefer to wait until we get rid of git-svn since it limits some of the capabilities of Git. Once we stop using it we'll probably change be able to use branches even more aggressively emoticon


I think git give's better tools to automate development process than SVN and I'm eager to see what you have a mind emoticon