Forums

Home » Liferay Portal » English » 3. Development

Combination View Flat View Tree View
Threads [ Previous | Next ]
toggle
Sơn Tuấn Nguyễn
Service builder - Foreign key - does it really work?
August 31, 2012 3:20 AM
Answer

Sơn Tuấn Nguyễn

Rank: Junior Member

Posts: 37

Join Date: March 1, 2010

Recent Posts

As i've developed for months now with MCV Portlet, service builder is cool.
And I know how to use foreign key like this:

<column name="locationId" type="Collection" entity="Location" mapping-key="id" />
<column name="locationId" type="String" />

However, yesterday I encountered a case that I could insert a record with locationId doesn't exist in parent table Location.

So the FK referenced in service.xml only helps if you update data in parent table, it will update data in child table.
And it doesn't check if inserted data in child table should exist in parent table, does it?

If this is true, we have to manually check for valid data right ?

Thanks in advance
Hitesh Methani
RE: Service builder - Foreign key - does it really work?
August 31, 2012 4:26 AM
Answer

Hitesh Methani

Rank: Regular Member

Posts: 160

Join Date: June 24, 2010

Recent Posts

Hello Sơn Tuấn Nguyễn,

Even we encountered the same problem.
Think you need to have a manual check in that case.

Regards,
Hitesh
Hitoshi Ozawa
RE: Service builder - Foreign key - does it really work?
September 1, 2012 8:49 PM
Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 7990

Join Date: March 23, 2010

Recent Posts

If you check the database, there really isn't any FK created. service.xml just defines specifies "relationships". If you studied service modelling in service oriented architecture, this is how it is suppose to be to make service autonomous.
Dimitrios Zigkos
RE: Service builder - Foreign key - does it really work?
October 19, 2012 4:01 PM
Answer

Dimitrios Zigkos

Rank: New Member

Posts: 6

Join Date: October 19, 2012

Recent Posts

Hello Hitoshi and all,
I try to handle the one-to-many relationship in Liferay. one of my problems is that there are no setters for the Collections in the case of FK. I look up the PersistenceImpl.class service builder creates, and I find lists of queries that refer to FKs. But those queries throw ERRORS when I run the portlet!

Lets say that we have the following entities in the service.xml (A persons has many jobs to do):
<entity name="Person" table="Person" local-service="true" remote-service="false">
<column name="personID" type="long" primary="true" />
<column name="firstName" type="String" />
<column name="lastName" type="String" />
<column name="jobs" type="Collection" entity="Job" mapping-key="jobID" />
...
</entity>
<entity name="Job" table="Job" local-service="true" remote-service="false">
<column name="jobID" type="long" primary="true" />
<column name="title" type="String" />
<column name="description" type="String" />
...
</entity>

Am I correct to consider that inside PersonLocalServiceImpl.java I can call the PersonUtil.getJobs(personID) for getting the List<Jobs> --(getter)?
If yes, how can I set the collection I have prepared elsewhere into this Person instance --(setter)?

Please assist...
Thank you,
Dimitrios Zigkos
David H Nebinger
RE: Service builder - Foreign key - does it really work?
October 23, 2012 2:09 PM
Answer

David H Nebinger

Rank: Liferay Legend

Posts: 6126

Join Date: September 1, 2006

Recent Posts

Liferay's Service Builder does not support 1-many or fkey relationships.

It is up to you to implement this.
Asmaa Ismail
RE: Service builder - Foreign key - does it really work?
October 23, 2012 4:35 PM
Answer

Asmaa Ismail

Rank: New Member

Posts: 10

Join Date: September 22, 2012

Recent Posts

I have a related Question here..
If I've a parent child case
Do I have to insert the parent alone and then loop on the child list and insert each object individually ??
Or how can I make the parent object persists its children with it??
Thanks in Advance,
Best Regards,
Asmaa
David H Nebinger
RE: Service builder - Foreign key - does it really work?
October 24, 2012 8:07 AM
Answer

David H Nebinger

Rank: Liferay Legend

Posts: 6126

Join Date: September 1, 2006

Recent Posts

You persist them all (parent and children) individually.
Jack Bakker
RE: Service builder - Foreign key - does it really work?
October 24, 2012 8:30 AM
Answer

Jack Bakker

Rank: Liferay Master

Posts: 500

Join Date: January 3, 2010

Recent Posts

how do u manage transactions and rollback David ?
David H Nebinger
RE: Service builder - Foreign key - does it really work?
October 24, 2012 8:47 AM
Answer

David H Nebinger

Rank: Liferay Legend

Posts: 6126

Join Date: September 1, 2006

Recent Posts

A transaction will be automatically wrapped around every service builder method that starts with add, update, delete (and I believe create and some others, but don't have a list handy).

To bind all of these into a single transaction, the key is to create one entry point in your XxxLocalServiceImpl class to handle the bulk insert/update:

 1public Parent addParentAndChildren(final Parent parent, final List<Child> children) {
 2  // persist the parent object the way you normally would
 3
 4  // handle the children here, whether you do a simple case of deleting the current children and blindly adding the children in the list
 5  // or a more complex method of selectively adding, removing, and updating children as given in the list.
 6
 7  // return the parent instance, this is standard for all add/update operations of Service Builder
 8  return parent;
 9}


Now when you call ParentLocalServiceUtil.addParentAndChildren(myParent, myChildren), this will all be handled within the scope of a single transaction.

So my original statement of "parent and children must be inserted manually" is still true, it is still up to the developer to manage the inserts.
Dimitrios Zigkos
RE: Service builder - Foreign key - does it really work?
October 24, 2012 1:31 PM
Answer

Dimitrios Zigkos

Rank: New Member

Posts: 6

Join Date: October 19, 2012

Recent Posts

I've finally resolved the problem with the FK.
I had to change the Collection of the Person entity as follows:
<column name="jobs" type="Collection" entity="Job" mapping-key="personID" />
and in the Job entity to insert a new column:
<column name="personID" type="long" />

This will allow the invocation of both:
PersonUtil.getJobs(personID)
PersonUtil.setJobs(List<Job>)

So, without the declaration of a FK, Liferay handles implicitly the personID coloumn of Job as a real FK.
It will justify the existence of that column in the queries in the class PersonPersistenceImpl.

I hope this helps.
Thank you all for the contribution.
Jack Bakker
RE: Service builder - Foreign key - does it really work?
October 24, 2012 4:10 PM
Answer

Jack Bakker

Rank: Liferay Master

Posts: 500

Join Date: January 3, 2010

Recent Posts

David, inside your addParentAndChildren, could you safely call other XxxLocalServiceUtil.add(Xxx xxx) or better to use xxxPersistence methods to do your add, update, delete
David H Nebinger
RE: Service builder - Foreign key - does it really work?
October 25, 2012 6:40 AM
Answer

David H Nebinger

Rank: Liferay Legend

Posts: 6126

Join Date: September 1, 2006

Recent Posts

You can safely call either. Since the transaction is already open, a new transaction will not be created for the internal calls. Transactions just get created when there is not already one in play...
Jack Bakker
RE: Service builder - Foreign key - does it really work?
October 26, 2012 5:22 PM
Answer

Jack Bakker

Rank: Liferay Master

Posts: 500

Join Date: January 3, 2010

Recent Posts

David H Nebinger:
You can safely call either. Since the transaction is already open, a new transaction will not be created for the internal calls. Transactions just get created when there is not already one in play...


Thanks David ; does this hold true across multiple service.xml with different tx-manager ?

I still have to dig into the belly of this stuff ; hoping u have more experience
David H Nebinger
RE: Service builder - Foreign key - does it really work?
October 27, 2012 1:28 PM
Answer

David H Nebinger

Rank: Liferay Legend

Posts: 6126

Join Date: September 1, 2006

Recent Posts

It should. The txn is created for the first method and the others where a txn would have been created (via AOP) will see there is already an open transaction and not create a new one...
Jack Bakker
RE: Service builder - Foreign key - does it really work?
October 28, 2012 9:37 AM
Answer

Jack Bakker

Rank: Liferay Master

Posts: 500

Join Date: January 3, 2010

Recent Posts

Thanks David