<img alt="Liferay" height="36" src="http://cdn.www.liferay.com/osb-www-theme/images/custom/heading.png" width="146" />

Rank: Junior Member

Posts: 61

Join Date: July 5, 2011

Hi I am using liferay 6.0.6. I am working with service builder where i generate entities and store data in them.
While setting primary Id for entity i use CounterLocalServiceUtil.increment(MemberContactDetails.class.getName()) method where "MemberContactDetails" is my entity name . but sometimes this method generates same PrimaryId again that's why I get exception and data doesn't get saved in table.

Does anyone knows reason behind this???

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 2:33 AM

Answer

Rank: Expert

Posts: 251

Join Date: March 4, 2011

Hi Samita,
Are you using like :

obj = *LocalServiceUtil.create(CounterLocalServiceUtil.increment(MemberContactDetails.class.getName()));
//set the values to obj
*LocalServiceUtil.update(obj);

Thanks,
Siby

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 2:52 AM

Answer

Rank: Junior Member

Posts: 61

Join Date: July 5, 2011

No.
Following is my code :-
long MemberContactDetailID = CounterLocalServiceUtil.increment(MemberContactDetails.class.getName());
MemberContDetail.setMemberContactDetailID(MemberContactDetailID);

Here "MemberContactDetails" is my entity and "MemberContactDetailID" is primary id.

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 3:23 AM

Answer

Jitendra Rajput

Rank: Liferay Master

Posts: 575

Join Date: January 7, 2011

#
# Set the number of increments between database updates to the Counter
# table. Set this value to a higher number for better performance.
#
counter.increment=100

try by setting above property to maximum value like 2000 and then verify . Not sure what exactly issue with your case.

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 4:45 AM

Answer

Rank: Expert

Posts: 251

Join Date: March 4, 2011

Hi,
How did you create this object variable : "MemberContDetail" ?
[ Tip: Please start all your variables with smaller case ]

Usually you can create this by :

1MemberContactDetails memberContDetail = MemberContDetailsLocalServiceUtil.create(CounterLocalServiceUtil.increment(MemberContactDetails.class.getName()))

In this case the primary key is already applied.
Check your code if this is the same logic.

Thanks,
Siby

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 5:54 AM

Answer

Rank: Junior Member

Posts: 61

Join Date: July 5, 2011

thanks for reply Siby.
I am creating entity by creating service.xml file. Variable is defined in service.xml.

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 6:08 AM

Answer

Rank: Expert

Posts: 251

Join Date: March 4, 2011

Hi Samita,
Yes I understand the entity name is defined in the service.xml.
Please post your full update code so that its easier to analyse.

Thanks,
Siby

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 4, 2013 11:29 PM

Answer

Rank: Junior Member

Posts: 61

Join Date: July 5, 2011

Following is my code :

PgDegreeMapping AddPgDegreeMapping = new PgDegreeMappingImpl();

long PgDegreeMappingID = CounterLocalServiceUtil.increment(PgDegreeMapping.class.getName());

AddPgDegreeMapping.setPgDegreeMappingID(PgDegreeMappingID);
AddPgDegreeMapping.setPgDegreeID(PgDegreeID);
AddPgDegreeMapping.setMemberCode(MemberCode);
AddPgDegreeMapping.setInstituteName(PgInstituteName);
AddPgDegreeMapping.setStartYear(PgStartYear);
AddPgDegreeMapping.setEndYear(PgEndYear);
AddPgDegreeMapping.setSpecialisation(PgSpecialization);

PgDegreeMappingLocalServiceUtil.addPgDegreeMapping(AddPgDegreeMapping);

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 5, 2013 2:25 AM

Answer

Rank: Expert

Posts: 251

Join Date: March 4, 2011

Hi Samita,
You are doing it wrong.
You should not instantiate the PgDegreeMappingImpl()
Instead do this :

1 PgDegreeMapping addPgDegreeMapping = PgDegreeMappingLocalServiceUtil.create(CounterLocalServiceUtil.increment(PgDegreeMapping.class.getName()));
2 //Set all the values
3 //Update

Thanks,
Siby

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 5, 2013 3:28 AM

Answer

Rank: Junior Member

Posts: 61

Join Date: July 5, 2011

Thanks for reply Siby. emoticon

I will try this solution.

Mark as an Answer

RE: CounterLocalServiceUtil.increment() not working proplerly

February 7, 2013 5:22 AM

Answer

Prakash Khanchandani

Rank: Regular Member

Posts: 209

Join Date: February 10, 2011

Also @Samita if possible start your variables with lowerCase.

Following conventions helps a lot in maintaining your code, you can refer to Java Code Conventions for more info, this is a nice and comprehensive code convention document and also explains the need for code-convention convincingly.

Thanks