Foren
Memoryleak in Liferay Portletbridge 3.1.0-ga?
Thomas Keßler, geändert vor 11 Jahren.
Memoryleak in Liferay Portletbridge 3.1.0-ga?
New Member Beiträge: 4 Beitrittsdatum: 20.12.10 Neueste Beiträge
Hi,
while running load tests we experienced some trouble with the class com.liferay.faces.bridge.scope.BridgeRequestScopeImpl.
VisualVM blamed it to hold an increasing amount the heap, finally 80%.
Our setup is: Weblogic Server 12.1.1, Liferay Portal 5.2 EE SP5, JSF2
Has anyone seen such behaviour before?
ciao
Thomas
while running load tests we experienced some trouble with the class com.liferay.faces.bridge.scope.BridgeRequestScopeImpl.
VisualVM blamed it to hold an increasing amount the heap, finally 80%.
Our setup is: Weblogic Server 12.1.1, Liferay Portal 5.2 EE SP5, JSF2
Has anyone seen such behaviour before?
ciao
Thomas
Neil Griffin, geändert vor 11 Jahren.
RE: Memoryleak in Liferay Portletbridge 3.1.0-ga?
Liferay Legend Beiträge: 2655 Beitrittsdatum: 27.07.05 Neueste Beiträge
Just curious -- do you have the following set to true in your WEB-INF/web.xml descriptor?
<context-param>
<param-name>[b]com.liferay.faces.bridge.bridgeRequestScopePreserved[/b]<!--
param-name-->
<param-value>[b]true[/b]</param-value>
</param-name></context-param>
Thomas Keßler, geändert vor 11 Jahren.
RE: Memoryleak in Liferay Portletbridge 3.1.0-ga?
New Member Beiträge: 4 Beitrittsdatum: 20.12.10 Neueste Beiträge
Hi,
thanks for you very quick answer!
No, the parameter has not been set in the web.xml.
ciao
Thomas
thanks for you very quick answer!
No, the parameter has not been set in the web.xml.
ciao
Thomas
Thomas Keßler, geändert vor 11 Jahren.
RE: Memoryleak in Liferay Portletbridge 3.1.0-ga?
New Member Beiträge: 4 Beitrittsdatum: 20.12.10 Neueste Beiträge
Hi,
I've take a look into the sources of the Bridge. It looks like the cleanup-Methods in BridgeRequestScopeManagerImpl are never called on weblogic server 12.1.1 running liferay 5.2.
ciao
Thomas
I've take a look into the sources of the Bridge. It looks like the cleanup-Methods in BridgeRequestScopeManagerImpl are never called on weblogic server 12.1.1 running liferay 5.2.
ciao
Thomas
Thomas Keßler, geändert vor 11 Jahren.
RE: Memoryleak in Liferay Portletbridge 3.1.0-ga?
New Member Beiträge: 4 Beitrittsdatum: 20.12.10 Neueste Beiträge
Hi!
I have found the cause of the memory leak. The BridgePhaseRenderImpl did not cleanup the bridgeRequestScopeCache correctly.
Here's the code snippet with my local bugfix of com.liferay.faces.bridge.BridgePhaseRenderImpl::cleanup
Could you please merge the bugfix into the next releases of the portlet bridge?
ciao
Thomas
I have found the cause of the memory leak. The BridgePhaseRenderImpl did not cleanup the bridgeRequestScopeCache correctly.
Here's the code snippet with my local bugfix of com.liferay.faces.bridge.BridgePhaseRenderImpl::cleanup
@Override
protected void cleanup() {
// If required, cause the BridgeRequestScope to go out-of-scope.
if ((bridgeContext != null) && !bridgeContext.isBridgeRequestScopePreserved()) {
bridgeRequestScopeCache.remove(bridgeRequestScope.getId());
}
super.cleanup();
}
Could you please merge the bugfix into the next releases of the portlet bridge?
ciao
Thomas
Neil Griffin, geändert vor 11 Jahren.
RE: Memoryleak in Liferay Portletbridge 3.1.0-ga?
Liferay Legend Beiträge: 2655 Beitrittsdatum: 27.07.05 Neueste Beiträge
Hi Thomas,
Thanks so much for reporting this problem. It actually occurs in two places in that class. The bug has been fixed in FACES-1445 and will appear in the next release.
Best Regards,
Neil
Thanks so much for reporting this problem. It actually occurs in two places in that class. The bug has been fixed in FACES-1445 and will appear in the next release.
Best Regards,
Neil