RE: Patch for 6.1.1 GA2 solving many issues

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi community,

As I've been doing some years ago, I've released a patch for solving many issues for 6.1.1 GA2. I've tried to patch only bugs, not improvements.

For patching just unzip the .diff file into liferay 6.1.1 source folder (same folder level as portal-impl, portal-web, etc folders) and use patch command in Linux or other tools for Windows. After that just compile and enjoy!

Example on how to apply patch in Linux: patch -p0 < patch_6.1.1_juan.diff

This patch solves this issues:

SECURITY/PERMISSIONS

LPS-30122 Able to delete any User
LPS-29054 - CLONE - A user with inherited private pages from a user group cannot access the pages
LPS-29208 JournalArticle permissions are not published for roles which permissions were removed
LPS-29008 Users with owner or non-portal administrator roles are allowed to reset omniadmin/default user password and settings
LPS-29379 Several permission checks don't account for customizable or virtual layouts
LPS-29476 Search portlet results are displaying for guest even without guest view permissions. (Web Content / Journal) -> Important issue where private web contents where showed in search result lists.
LPS-29597 members without permissions are able to access private pages
LPS-29743 Users can still view portlet in private pages even through view permission is unchecked
LPS-29516 Rollback LPS-26318 (Web Content Display portlet is not visible to guest even with guest view permission)
LPS-29505 When using search, content scoped to groups may not be handled properly
LPS-30418 Add dynamic inheritance check to getFileEntries().
LPS-30518 Apply same check as DLStoreImpl#getFile
LPS-30015 guest can's search the bookmark which permission is "Viewable by Anyone(Guest Role)
LPS-30437 Users without permission can create folders/files in the root folder
LPS-30188 In default, site member can be able to add documents in home directory of document and media portlet

BROWSER/JAVASCRIPT

LPS-29041 Path doesn't return with correct protocol -> Critical issue for users who use load balancer using ssl only.
LPS-29154 Control Panel theme breaks CKeditor dialog in IE8
LPS-29594 Poll Display portlet does not show correctly the bars when showing the poll's result
LPS-28924 - Editing a Subcategory converts it from child to sibling
LPS-29645 Unable to download a document in IE8 with SSL -> Without this patch, you couldn't download documents and show inline (PDF) in IE if using SSL only.
LPS-30181 WebServerServlet URLs do not correctly set the content length on HTTP headers for non-image files

TEMPLATES/STAGING

LPS-28813 The article's default template isn't published to remote live
LPS-28977 - Temp file not being deleted after LAR import through hook
LPS-29072 ArticleUrlTitle may change when publishing to live
LPS-29072 Keep the urlTitle when updating
LPS-29370 Wrong Page Template export with some porlet
LPS-29449 Delete Missing Pages option during Publish deletes all live pages except the selected pages
LPS-29474 Pages created w/Templates that include Documents and Media Portlet w/Global Scope creates local copy of Doc & Media
LPS-29629 Fix deleteMissingLayouts when there is no staging group
LPS-29495 Journal article export/import does't work properly when last revision is expired
LPS-28995 Disable non "site pages variations" pages in selection list of the pop up Publish to Live
LPS-29021 If a portlet is staged, this should be checked by default in publish to live
LPS-28147 Portlet permissions removed when resetting site to site template


DOCUMENTS & MEDIA/WEBDAV

LPS-28094 - Document Library: Moving documents between folders results in error accessing file
LPS-29108 WebDav in Windows XP seemed broken in 6.1. This patch solves all those issues. -> Important issue for WebDav + XP users
LPS-29320 Document & Media Portlet Search returns inconsistent results
LPS-29105 Documents and Media Document Types and Metadata Sets does not show the right number of results
LPS-29786 Unable to upload a file with valid extension using multiple uploader after setting "Allowed File Extensions" in control panel
LPS-29678 Getting Content Stream should get the latest version
LPS-29574 If image/document already exist, Upload Image/Document From Web Content Portlet Issue will throw errors in log but and not display "image/document already exists or image already uploaded"
LPS-25911 WebDAV URL will have "null" as context path for the company group
LPS-30621 move folders and documents fail in unix or linux platform when crossing file system
LPS-29928 Editing documents through WebDAV resets Custom Field values and Categories for document

PLUGINS

LPS-29000 DestinationEventListener now removed on plugin undeployment
LPS-29103 Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)


PERFORMANCE/STABILITY

LPS-29268 Simple DOS attack on PortletPreferences
LPS-29323 Long load time when accessing files with links like '/c/document_library/get_file
LPS-29406 Images in blog, wiki or message board render slowly in Internet explorer 7 and 8
LPS-29508 Small memory optimization for PermissionCheckerBagImpl instances
LPS-29031 Finder Cache is not properly invalidated in a cluster environment
LPS-30243 clear resources so portal can be restarted in app servers (weblogic)

UPGRADE

LPS-29479 Non-Liferay tables upgraded on Oracle -> important issue for Oracle users.
LPS-29349 Startup exception when en_US not present
LPS-29879 Verify corrupt layout data


LDAP

LPS-29100 Several user fields are reset after LDAP import
LPS-29003 Wrong documentation in LPS-28639, must manually set java system properties instead of relying on system.properties file
LPS-30121 Defined LDAP values are overriden by database values after configuration


MISC.

LPS-28949 FriendlyURL to non-existing web content does not redirect correctly
LPS-29086 Search Portlet 'Return to Full Page' Inconsistent
LPS-29057 Asset Publisher - "Does not Contain" Filter not working
LPS-29324 Inconsistent behavior encountered with 'AssetTagServiceUtil' search method when logging in as 'Power User' vs 'Admin' user
LPS-29216 Internal Server Error in Wiki, with "Select Page" scope
LPS-29378 File Attachments Are Being Deleted When Dynamic Data Lists Records are Deleted
LPS-29202 /c/journal/get_articles search on structureId doesn't return any articles even when there are correct articles present
LPS-29360 Related Assets Portlet does not work when global or multiple scopes(groups) are selected in Asset Publisher
LPS-29572 Related assets for wikis does not correct count the number of pages
LPS-29668 Fixing void return type function calls' UnsupportedOperationException throwing.
LPS-29626 Mime type detection closes stream during import
LPS-29405 Double indexing of web content overwrites version with oldest version
LPS-30058 NPE when viewing a page with a portlet scoped to a layout that doesn't exist
LPS-29715 Sitemap.xml date is not valid ISO8601 date
LPS-30524 Using Virtual Hosts when editing a web content in the AP makes you authenticate again
LPS-29716 Fix sitemap.xml for portal instances
LPS-29523 Arguments for JSON actions does not have fail back deserilization
LPS-29781 Unable to save categories when adding or updating users
LPS-27624 Being a member of an Organization with no Pages will reduce the number of drop-down items in Go To
LPS-29845 jsonws ctx root
LPS-29904 Regression issue with portal-ext.properties loading order (order should be reversed)
LPS-30185 Can not send email to mutilple recipients
LPS-30026 SecureFilter fails to populate companyId basic auth requests for a particular session

EDIT: added simple categories for summarize issues.
EDIT 2012-10-30. Added issues:

LPS-30188 In default, site member can be able to add documents in home directory of document and media portlet
LPS-30026 SecureFilter fails to populate companyId basic auth requests for a particular session
LPS-30185 Can not send email to mutilple recipients
LPS-29904 Regression issue with portal-ext.properties loading order (order should be reversed)
LPS-29845 jsonws ctx root
LPS-30181 WebServerServlet URLs do not correctly set the content length on HTTP headers for non-image files
LPS-27624 Being a member of an Organization with no Pages will reduce the number of drop-down items in Go To
LPS-30121 Defined LDAP values are overriden by database values after configuration
LPS-29781 Unable to save categories when adding or updating users
LPS-29928 Editing documents through WebDAV resets Custom Field values and Categories for document
LPS-30437 Users without permission can create folders/files in the root folder
LPS-29523 Arguments for JSON actions does not have fail back deserilization
LPS-29103 Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)
LPS-30015 guest can's search the bookmark which permission is "Viewable by Anyone(Guest Role)
LPS-29716 Fix sitemap.xml for portal instances
LPS-30418 Add dynamic inheritance check to getFileEntries().
LPS-30518 Apply same check as DLStoreImpl#getFile
LPS-30524 Using Virtual Hosts when editing a web content in the AP makes you authenticate again
LPS-30243 clear resources so portal can be restarted in app servers (weblogic)
LPS-29715 Sitemap.xml date is not valid ISO8601 date
LPS-30621 move folders and documents fail in unix or linux platform when crossing file system

[Sampsa Sohlman, geändert vor 11 Jahren.]

Wow Juan, that includes 60 fixes !

Eres un Liferay

How many of these you made your self?

[Juan Gonzalez P, geändert vor 11 Jahren.]

What do you mean by "made myself"? These patches come from github, but I had to do slightly changes because some of them changed other behaviour.

[Sampsa Sohlman, geändert vor 11 Jahren.]

I was only wondering how big work was that since fix amount is huge.

Thanks again.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Well, it required some minutes in a daily basis (many hours in total) because I had to follow issues, watch how to solve them properly, watch all necessary changes, etc. So this work started in 1th August, when 6.1.1 was out.

Of course had to see all the relations between issues too, because some of them caused regressions on another issues.

Fortunately at this point I see is stable enough to publish it.

In fact I used this in our production upgrade from 6.0.5 to 6.1.1 GA2 and was 100% successful and stable.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Could you show us the steps for applying the patches for a non expert like us, that loves liferay, downloaded the source code and tests knew things. :=)

I have the 6.1.1 GA2 ubuntu 12.04 tomcat 7.0.27 java sun jre 6.0.35

thanks in advance.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Edited first post. If you are using Linux, after unzip then execute patch -p0 < patch.diff

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

thanks :=)

[Ákos Gábriel, geändert vor 11 Jahren.]

Great job, thank you!

If you're interested I can offer you a continuous integration environment (based on Jenkins) where a lot of repetitive tasks can be automated.

Akos

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks for your help, Akos.

[Linus Sphinx, geändert vor 11 Jahren.]

Juan Gonzalez P:

In fact I used this in our production upgrade from 6.0.5 to 6.1.1 GA2 and was 100% successful and stable.

Best news I've heard in a while. Thanks

[Luis Mas, geändert vor 11 Jahren.]

Great Juan!!!

Eres grande!!! Te hacemos la ola!!!

Enhorabuena y gracias!!!

[Juan Gonzalez P, geändert vor 11 Jahren.]

Gracias, Luis. Espero que te sirva :-D

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

compilado y trabajando al 100% gracias Juan, Saludos desde Sonora México.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Gracias Gabriel,

Glad it worked for you

[Mika Koivisto, geändert vor 11 Jahren.]

Nice work Juan. Have you by any change published your branch in Github?

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks Mika,

Ups, I didn't. I have all this commits in our SVN separate by LPS, perhaps should have to migrate to github too.

BTW, in this thread

http://www.liferay.com/community/forums/-/message_boards/message/16708189

we are talking about making all of these patches available to community.

[Sergio Ramazzina, geändert vor 11 Jahren.]

Thanks Juan for your work!

Sergio

[Miguel Ángel Júlvez, geändert vor 11 Jahren.]

Como siempre Juan... ¡¡te sales del gráfico tio!!

Un millón de gracias

[Juan Gonzalez P, geändert vor 11 Jahren.]

De nada Miguel ;)

Hope you'll post here how it goes for you...

[Rafael Lluis, geändert vor 11 Jahren.]

Muchas Gracias Juan. Bueno, yo estoy usando la versión publicada en https://www.lcepatchers.org/. Entiendo que es más o menos lo mismo. Desde luego a mí me está funcionando genial.

Gracias de nuevo

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi Rafael,

Yes, in fact all the work is being done there instead of here...I pushed some commits yesterday.

[Gabriel Leon Leyva, geändert vor 10 Jahren.]

Good morning Juan, I have a problem with assets publisher, I had a blog page but for making easier remove blog portlet and replace it with asset publisher, but on normal user no matter what permission I configure the asset publisher does not display the "Add Blog" button. Is this a bug how Can I Patch it? (I have the last version of liferay patched) of your site.

In the normal blog portlet they have permission to add a blog entry

Found the problem (edit control must be checked) in order to see the add new button it's there a work around?

I if edit control is checked users can delete portlets

Thanks :-)

[Juan Gonzalez, geändert vor 10 Jahren.]

Sorry Gabriel, in this case seems that same permissions is used for both actions.

Perhaps you can search if there's an issue like that in JIRA.

[James Falkner, geändert vor 11 Jahren.]

Juan! This is really helpful, thanks for doing this! You provide a nice in-between-GA service for our community. My hope is that we can cut GA releases more frequently in the future, and lessen your workload

Now you should hook up with Aad and Co. and get some builds going!

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks James. This is one of the advantages of having open source and everything in github.

Who is Aad?

[James Falkner, geändert vor 11 Jahren.]

Juan Gonzalez P:

Thanks James. This is one of the advantages of having open source and everything in github.

Who is Aad?

Yep, open source is great! What's even better is your willingness to volunteer your time to help everyone out So thanks again for that!

Aad Nales started the effort over here in this thread

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok James, I am aware of that thread.

Thanks.

[Karla Williams, geändert vor 11 Jahren.]

Juan, is this just for CE? Is there any way to obtain the path for EE? or EE Trial?

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi Karia,

Nope, this is for CE (6.1.1 GA2).

BTW, why you need for EE? Having that license you should get patches from Liferay.

[Karla Williams, geändert vor 11 Jahren.]

Still prototyping using the Trial version of EE

[Alain Dresse, geändert vor 11 Jahren.]

Many thanks Juan !

[Juan Gonzalez P, geändert vor 11 Jahren.]

Another patch version with more solved issues in next days.

Stay tuned!

[Ivano Carrara, geändert vor 11 Jahren.]

Hi Juan,

Thank you for your valuable work !!

Yesterday I posted a new thread with title "Kaleo Error retrieving tasks after migration from 6.0.6 to 6.1.1 CE GA2" that you can find here:
http://www.liferay.com/community/forums/-/message_boards/message/17021394

Please, could you contact me for a private question ?
If yes, write me to [e-mail]

Thank you in advance !
Ivano C.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ivano,

I've accepted your friend request. Guess now you can contact me with private message...

[Ivano Carrara, geändert vor 11 Jahren.]

Hi Juan,

I can't see your email address on your profile page, so I wrote on your wall...

Thank you !

Ivano C.

[Luis Mas, geändert vor 11 Jahren.]

Juan Gonzalez P:

Another patch version with more solved issues in next days.

Stay tuned!

WOW, you alone is the Community Patcher!

[Troy Griffitts, geändert vor 11 Jahren.]

Juan,

Thank you so much for all that you do. We've been wanting to upgrade to GA2 but cannot because of a regression.

We currently use the Liferay javascript API, which in turn uses the jsonws API, to create forum posts, and GA2 shipped with a bug that would not allow the jsonws call to succeed. This patch fixed the problem for us. If you might be so kind as to include it in your next patch bundle, we would be so appreciative. Thank you for considering.

http://issues.liferay.com/browse/LPS-29523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok Troy, added to my issues list for next patch.

[Ivano Carrara, geändert vor 11 Jahren.]

Hi Juan,

I would like to submit to your attention this issue: Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)
You can find the issue here: http://issues.liferay.com/browse/LPS-29103

In fact, in presence of complex plugins that contains shared beans (service layer, dao layer and such), after you deployed it you have to manually swap the position of some listeners definition in web.xml file.

The patch it is here: https://github.com/vpugar/liferay-portal/blob/6.1.x_LPS-29103/portal-impl/src/com/liferay/portal/tools/deploy/BaseDeployer.java
Without the above patch, the deploy of your plugin fails.

Thank you for your attention !

Ivano C.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ivano,

Yep that issue was in my issues list already, but didn't patch (probably because I didn't really need it).

Will be in next patch

[Timmy M., geändert vor 11 Jahren.]

It would be great if we could make these patches available in a library or (ext) plugin?

[Chris Huff, geändert vor 11 Jahren.]

Juan,

I applied the patch in Linux on the contents of the sourceforge downoload "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip" and got a bunch of hunk rejects. (some did execute, but lots of rej files generated). Am I supposed to use the 6.1.x branch from svn, or the zip file (above) from sourceforge?

[Juan Gonzalez P, geändert vor 11 Jahren.]

Please, post the steps you did (and directories where you did them) . It should work.

[Chris H, geändert vor 11 Jahren.]

Juan,

Steps:
- Unzip sourceforce source package "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip"
- place diff file "patch_6.1.1_juan.diff" in "liferay-portal-src-6.1.1-ce-ga2" folder
> cd liferay-portal-src-6.1.1-ce-ga2
> patch -p0 < patch_6.1.1_juan.diff

Resulted in >60% hunk rejects.

UPDATE:

I used the latest SVN checkout of 6.1.x Branch and had no hunk errors! Success.
So be sure to pass it on that the 6.1.1 source from Sourceforge is not working with the patch for some reason.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Great Chris,

It should be same source, but seems it isn't :-D. Very strange that >60% resulted in failed rejects anyway.

[Luis Mas, geändert vor 11 Jahren.]

Chris H:

Juan,

Steps:
- Unzip sourceforce source package "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip"
- place diff file "patch_6.1.1_juan.diff" in "liferay-portal-src-6.1.1-ce-ga2" folder
> cd liferay-portal-src-6.1.1-ce-ga2
> patch -p0 < patch_6.1.1_juan.diff

Resulted in >60% hunk rejects.

UPDATE:

I used the latest SVN checkout of 6.1.x Branch and had no hunk errors! Success.
So be sure to pass it on that the 6.1.1 source from Sourceforge is not working with the patch for some reason.

I've read in some place that Sourceforge source has something with windows chars and you have to pass a sentence before [(in the security team forum):

"It is recommended that you download the source from Github (from here). If you have downloaded the source code from SourceForge.net, be aware that SourceForge code sometimes contains Windows-style line endings, and you may need to first convert them to unix-style line endings using something like:

cd $LIFERAY_SRC_HOME; find . -type f -exec dos2unix {} \;"



maybe is because of that?

[Chris H, geändert vor 11 Jahren.]

That's what I thought, but then I considered that about 40% of the hunks were processed properly, so I suppose if that were the problem then it would reject all patches and not some :-)

[Hitoshi Ozawa, geändert vor 11 Jahren.]

It has to do with the CR LF at the end of a row. Unfortunately, liferay source code didn't standardize on this so there are some code with CR+LF and some with just LF. That's why some are processed properly while other are not.

[Sampsa Sohlman, geändert vor 11 Jahren.]

I have to say thanks again.

This patch did solve some serious issues on the social office installation that I made. Like moving the document library article and then missing link.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Happy to hear that. Thanks for telling!

I have almost finished my next patch with some other issues (some of them were requested by users in this forum thread).

[K Boyce, geändert vor 11 Jahren.]

Hey.. this is awesome. Any eta on LPS-29103 being included?

[Juan Gonzalez P, geändert vor 11 Jahren.]

After being in Liferay Spain Symposium and taking some days for rest, probably will have ready by the end of week (thursday, friday...).

That isssue is already in patch but wanted to include 2 additional LPS.

[K Boyce, geändert vor 11 Jahren.]

It's in the patch on this post already? Also is there any possibility of a binary patch?

[Juan Gonzalez P, geändert vor 11 Jahren.]

K Boyce:

Also is there any possibility of a binary patch?

What do you mean by "binary patch"? You can compile for any server you want. You can search in liferay.com wiki or user guide to know how to...

[Juan Gonzalez P, geändert vor 11 Jahren.]

As you can see, yesterday I've updated the patch.

Enjoy

[Gaurav Jain, geändert vor 11 Jahren.]

Wow thats really simply awesome.

Thanks Juan for the great work.

I am now eager to use the patches on my portal, will be doing it soon

[Troy Griffitts, geändert vor 11 Jahren.]

Juan,

I'm so grateful for your efforts. Thank you.

I've had a few problems that I'll work through, but wanted to report (some have already been mentioned on this thread)

The source download link on the main liferay page here:
https://www.liferay.com/downloads/liferay-portal/additional-files

points to the sourceforge download, which doesn't work with your patch.

I had to use the git download mentioned in this thread from here:
https://github.com/liferay/liferay-portal/tags

I downloaded 6.1.1-ga2.zip and the patch seems to apply mostly clean, but there are a few hunks that fail.

Here are my exact steps:

[liferay@VMR-DEV GA2-src]$ wget https://nodeload.github.com/liferay/liferay-portal/tarball/6.1.1-ga2 -O liferay-liferay-portal-6.1.1-ga2-0-gfe70851.tar.gz
[liferay@VMR-DEV GA2-src]$ tar xzfv liferay-liferay-portal-6.1.1-ga2-0-gfe70851.tar.gz
[liferay@VMR-DEV GA2-src]$ cd liferay-liferay-portal-fe70851/
[liferay@VMR-DEV liferay-liferay-portal-fe70851]$ unzip ../patch_6.1.1_juan_3.zip
[liferay@VMR-DEV liferay-liferay-portal-fe70851]$ patch -p0 < patch_6.1.1_juan_3.diff > patch-results.txt
[liferay@VMR-DEV liferay-liferay-portal-fe70851]$ grep rejects patch-results.txt
1 out of 1 hunk FAILED -- saving rejects to file portal-service/src/com/liferay/portal/kernel/lar/BasePortletDataHandler.java.rej
2 out of 2 hunks FAILED -- saving rejects to file portal-impl/src/META-INF/search-spring.xml.rej
1 out of 2 hunks FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/verify/VerifyLayout.java.rej
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/events/BaseDefaultDDMStructureAction.java.rej
1 out of 4 hunks FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/search/SearchPermissionCheckerImpl.java.rej
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/configuration/easyconf/ClassLoaderAggregateProperties.java.rej
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/spring/context/PortalContextLoaderListener.java.rej
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/lar/PermissionImporter.java.rej

Any ideas?

Thank you again. We have not been able to use 6.1.1 GA2 because of the regression I mentioned earlier. Your patch makes GA2 deployable! You deserve a raise! Or at least a beer.

Troy

[Juan Gonzalez P, geändert vor 11 Jahren.]

Did you try downloading from 6.1.x in SVN? (as someone said before)

You can try downloading from 6.1.x branch in github:

https://github.com/liferay/liferay-portal/tree/6.1.x

[Juan Gonzalez P, geändert vor 11 Jahren.]

In fact I used a local SVN repo for patching files (and creating patch).

Perhaps is a problem between SVN <-> git and/or CR/LF characters as Hitoshi said. (I used Windows to create patch).

[Juan Gonzalez P, geändert vor 11 Jahren.]

If someone did patch properly, please post here your environment (windows, linux), where did you download the 6.1.1 sources, etc.

Thanks

[Troy Griffitts, geändert vor 11 Jahren.]

Juan,

I've run through the rejects and it looks like it was all about whitespace. I tried using patch -l (to ignore whitespace) but still got the rejects. Not sure. Anyway. Here is an updated patch that applied cleanly against the git tag. So these steps patch for me. Now to try building...

[liferay@VMR-DEV GA2-src]$ wget https://nodeload.github.com/liferay/liferay-portal/tarball/6.1.1-ga2 -O liferay-liferay-portal-6.1.1-ga2-0-gfe70851.tar.gz
[liferay@VMR-DEV GA2-src]$ tar xzfv liferay-liferay-portal-6.1.1-ga2-0-gfe70851.tar.gz
[liferay@VMR-DEV GA2-src]$ cd liferay-liferay-portal-fe70851/
[liferay@VMR-DEV liferay-liferay-portal-fe70851]$ wget http://vmr-dev.uni-muenster.de/liferay-liferay-portal-6.1.1-ga2-0-gfe70851_juan_3.diff
[liferay@VMR-DEV liferay-liferay-portal-fe70851]$ patch -p1 < liferay-liferay-portal-6.1.1-ga2-0-gfe70851_juan_3.diff

Juan, you might want to try to apply my patch against a clean svn repo and then diff a repo patched with your patch and one patched with my patch and be sure everything is the same.

Hope this helps,

Troy

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok Troy thanks for your work.

Will try this in linux this evening and see what are the differences between two patches.

Will se if I can re-create the patch in linux and/or make that commit to github Community Patcher's repo, something is pending since some weeks.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Please can you try using this?

patch -p0 -l --binary < patch.diff

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ups so many differences in your patch.

Will try other way...

[Juan Gonzalez P, geändert vor 11 Jahren.]

Mmm I won't have access to my sources until friday.

It seems there are some known problems using svn diff (as I do) and then patch.

On friday will try to create a better patch and test that it can be patched using "patch".

But probably I will end using another tool for creating the patch. This time in Linux.

Sorry for the inconveniences.

[Luis Mas, geändert vor 11 Jahren.]

Juan, where did you uploaded the new patch? Sorry if it's an obvious question
Regards, Luis
PD. Eres un megacrack.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Luis, it's an attachment in first post.

Un abrazo!

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Juan Good morning, I try to apply the patch and gives this erros Reversed (or previously applied) patch detected! Assume -R?

[Juan Gonzalez P, geändert vor 11 Jahren.]

Gabriel,

This is a whole patch, so if you already patched with previous version, you'll have to repeat process again.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Thanks Juan, Downloading Source again. :=)

[Juan Gonzalez P, geändert vor 11 Jahren.]

Great,

Please Gabriel could you post your steps for patching it (sucessfully)?

BTW I am having problems too when patching in linux. Only those files though, will continue investigating...

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

I didnt yet, I will download whole source and try to patch again..

[Sampsa Sohlman, geändert vor 11 Jahren.]

Hi Gabriel,

Here is the 7z containing changed only files (not as patch format). So you can unzip this top of your downloaded source and compile it with ant all.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Thanks Sampsa I'll do that :=)

[Hitoshi Ozawa, geändert vor 11 Jahren.]

I'm sure Juan is testing before releasing patches but I'm wondering if anyone has actually done verification on these patches to make sure they actually solve the problem. Liferay sometimes do not have all the required modification links to github commits in jira issue to solve a particular problem. It's always to nice to get third party verification just in case. :-)

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hitoshi Ozawa:

I'm sure Juan is testing before releasing patches but I'm wondering if anyone has actually done verification on these patches to make sure they actually solve the problem. Liferay sometimes do not have all the required modification links to github commits in jira issue to solve a particular problem. It's always to nice to get third party verification just in case. :-)

Yep, that's the reason I am looking for every commit in github :-D. Hopefully I didn't miss any. It would be great if someone can double check this anyway.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Sampsa does this backup have the latest patch version that Juan released?

[gordon daniels, geändert vor 11 Jahren.]

Juan: you mention that the wiki tells how to patch, but the only thing I found was about patching EE. I use CE and have a tomcat bundle. How do I go about patching it? Could you point me to the steps?

[Hitoshi Ozawa, geändert vor 11 Jahren.]

Juan: you mention that the wiki tells how to patch, but the only thing I found was about patching EE. I use CE and have a tomcat bundle. How do I go about patching it? Could you point me to the steps?

I think you're looking at instructions for applying EE patches. These are provided by liferay.com to EE subscribers. I think instructions on applying Juan's patches were mentioned earlier in this thread. You'll need to get liferay 6.1.1 CE GA2 source file any apply the patch command and then do an "ant all" to build.

[gordon daniels, geändert vor 11 Jahren.]

Hitoshi: thanks! as always, you have been a big help.

thanks again

[Sampsa Sohlman, geändert vor 11 Jahren.]

Gabriel Leon Leyva:

Sampsa does this backup have the latest patch version that Juan released?

Yes it have (if I have not done mistake). It is having only the changed files, which can be copy over to Liferay source dir. Our custom Liferay build has been mavenized (it is maven project, we like everything to be maven), so the Juan's patch did not directly apply to our build system. So had to see which files where been changed and add them to our maven build and patch really did fix things.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

ok becouse I got error while compile, the problem that I compile with ant.

[Sampsa Sohlman, geändert vor 11 Jahren.]

I did try this out again.

What I made it to work at windows: (I have ant etc. installed)

create directory to work on named 611patched

unzip liferay-portal-tomcat-6.1.1-ce-ga2-20120731132656558.zip that 611patched directory.

change the name of liferay-portal-6.1.1-ce-ga2 to bundles

unzip liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip to 611patched directory and you see new directory liferay-portal-src-6.1.1-ce-ga2

copy patch.7z to liferay-portal-src-6.1.1-ce-ga2 directory

goto command line to that liferay-portal-src-6.1.1-ce-ga2 directory and run command ant all

I made exactly like this and after that I had patched liferay at liferay-portal-6.1.1-ce-ga2 directory.

Anyway, I think we need to put this to git.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Just FYI, I will try to solve this definitely today. Will tell how it goes....

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Juan didnt notice the first time but I'm getting errors in the patch, (ubuntu, Java 1.6, ant 1.8.4) patch 2.6.1

[Juan Gonzalez P, geändert vor 11 Jahren.]

Wow I am finding some weird problems (patching, compilation , files that should be patched but aren't etc).

Tomorrow will try to make a diff from original sources to my source code and see if then I can create a proper diff.

If I can't, will upload the code to github.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Going to commit to github.

Subscribe to this thread to see latest news:

http://www.liferay.com/community/forums/-/message_boards/message/17668653

[gordon daniels, geändert vor 11 Jahren.]

Juan: I just wanted to say thanks for this great effort. And thanks to all you others for this.

Does this mean we will be able to download a patched tomacat bundle soon?

thanks again

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks gordon

Yep, builds will be here:

https://www.lcepatchers.org/

[Luis Mas, geändert vor 11 Jahren.]

Juan Gonzalez P:

Thanks gordon

Yep, builds will be here:

https://www.lcepatchers.org/

Juan, they could also be here: https://github.com/Liferay-Patchers-Community/liferay-portal/downloads (en lecpatchers.org reference to this URL).

Regards, Luis

[gordon daniels, geändert vor 11 Jahren.]

Luis: thank you for your efforts. This will mean alot to the community. There are those of us who are a one man shop trying to learn new skills and can not afford the EE version.

thanks again

[Juan Gonzalez P, geändert vor 11 Jahren.]

Luis Mas:

Juan Gonzalez P:

Thanks gordon

Yep, builds will be here:

https://www.lcepatchers.org/

Juan, they could also be here: https://github.com/Liferay-Patchers-Community/liferay-portal/downloads (en lecpatchers.org reference to this URL).

Regards, Luis

Well, that's not really true (and the reason why I pointed to icepatchers.org).

Right now the patched version is in its branch, not master:

https://github.com/Liferay-Patchers-Community/liferay-portal/tree/6.1.1-ga2-patched

[Fuad Efendi, geändert vor 11 Jahren.]

Hi Juan,
This branch contains single patch made yesterday... isn't it? Great work... but I don't know what to use right now: *.dif file or version from branch?
I also don't trust to 6.2.0 M1...
Thanks

P.S. Just as a random pick, official branch contains LPS-30438 (authored 24 days ago), and your forked version doesn't have it (and this thread doesn't mention it) in 6.1.x nor in 6.1.1-ga2-patched... during previous happy years I usually relied on A.B.x versions from SVN (ending with "x") and/or trunk version...


P.P.S.
I see that you are applying to 6.1.1 some fixes officially being made only for 6.2.x... with some minor changes... am I right?


I have some problems,
patching file portal-impl/src/system.properties
Hunk #1 FAILED at 204.
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/system.properties.rej
(Stripping trailing CRs from patch.)
patching file portal-impl/src/resource-actions/documentlibrary.xml
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/resource-actions/documentlibrary.xml.rej
(Stripping trailing CRs from patch.)
patching file portal-impl/src/portal.properties
Hunk #1 FAILED at 453.
Hunk #2 FAILED at 2876.
Hunk #3 FAILED at 7720.
Hunk #4 FAILED at 8369.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi Fuad,

Fuad Efendi:

Hi Juan,
This branch contains single patch made yesterday... isn't it? Great work... but I don't know what to use right now: *.dif file or version from branch?
I also don't trust to 6.2.0 M1...
Thanks

I would download zip or clone github repository (and fetch branch after that as usual in git)

Fuad Efendi:

P.S. Just as a random pick, official branch contains LPS-30438 (authored 24 days ago), and your forked version doesn't have it (and this thread doesn't mention it) in 6.1.x nor in 6.1.1-ga2-patched... during previous happy years I usually relied on A.B.x versions from SVN (ending with "x") and/or trunk version...
P.P.S.
I see that you are applying to 6.1.1 some fixes officially being made only for 6.2.x... with some minor changes... am I right?

About LPS-30438, yep they were commited to 6.1.x branch only few weeks ago, and I didn't considered important enough for the patch. The community patchers repo probably have been created before that patch, but should be easy to incorporate those changes.
About the second thing, I don't think so. All fixes are done to 6.1.x branch too.

Fuad Efendi:

I have some problems,
patching file portal-impl/src/system.properties
Hunk #1 FAILED at 204.
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/system.properties.rej
(Stripping trailing CRs from patch.)
patching file portal-impl/src/resource-actions/documentlibrary.xml
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file portal-impl/src/resource-actions/documentlibrary.xml.rej
(Stripping trailing CRs from patch.)
patching file portal-impl/src/portal.properties
Hunk #1 FAILED at 453.
Hunk #2 FAILED at 2876.
Hunk #3 FAILED at 7720.
Hunk #4 FAILED at 8369.

As I said before, is better at the moment downloading whole branch from github . I would like to recommit everything so diff files are made only for affected lines (righ now the whole files are changed), but don't know when I will have time for this (hopefully some community patcher's member can help in this).

Please compile the source and make your tests. Will be helpful for sure.

[Fuad Efendi, geändert vor 11 Jahren.]

I think last problem because of recent changes in 6.1.x; can't apply patch.

So I am going with 6.1.1 but I need tar.gz from GitHub instead of SourceForge...

but still the same:

1 out of 4 hunks FAILED -- saving rejects to file portal-impl/src/com/liferay/portal/search/SearchPermissionCheckerImpl.java.rej
missing header for unified diff at line 21852 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 21852
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
| }
--------------------------

[Juan Gonzalez P, geändert vor 11 Jahren.]

Fuad Efendi:

I think last problem because of recent changes in 6.1.x; can't apply patch.

So I am going with 6.1.1 but I need tar.gz from GitHub instead of SourceForge...

Yep, github is the right (and only) source for me.

[Fuad Efendi, geändert vor 11 Jahren.]

I forgot to add: Mac OS Lion...

[Fuad Efendi, geändert vor 11 Jahren.]

Ok, two files conflicting only, I'll apply changes manually if necessary...

[Juan Gonzalez P, geändert vor 11 Jahren.]

You can download whole branch from here if you don't wanna patch:

https://github.com/Liferay-Patchers-Community/liferay-portal/archive/6.1.1-ga2-patched.zip

[Afif Abu Bakar, geändert vor 11 Jahren.]

Hi,

Is this issue fixed in this patch? http://issues.liferay.com/browse/LPS-30369

[Juan Gonzalez P, geändert vor 11 Jahren.]

Afif Abu Bakar:

Hi,

Is this issue fixed in this patch? http://issues.liferay.com/browse/LPS-30369

Please read first post.

[Afif Abu Bakar, geändert vor 11 Jahren.]

Juan Gonzalez P:

Afif Abu Bakar:

Hi,

Is this issue fixed in this patch? http://issues.liferay.com/browse/LPS-30369

Please read first post.

Okay sorry about that. I'm just curious. Based on that issue, you cannot deploy portlet in layout template. So since it is not listed in first post, surely the issue is still there.
But how you guys deploy portlet then? I'm having that issue now and looking for a solution.

[Troy Griffitts, geändert vor 11 Jahren.]

Juan,

I've downloaded and tried to compile from the first link, quoted below, but get compile errors. The first error:

[javac] 1. ERROR in /space/home/liferay/src/liferay-portal-6.1.1-ga2-patched/portal-service/src/com/liferay/portal/repository/proxy/BaseRepositoryProxyBean.java (at line 179)
[javac] List<FileEntry> fileEntries = _baseRepository.getFileEntries(
[javac] folderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException


The patch I posted earlier applies and builds cleanly, but I can't confirm that it actually works. I was planning to abandon it in favor of your git fork. Let me know if I can help.

Troy

Juan Gonzalez P:

You can download whole branch from here if you don't wanna patch:

https://github.com/Liferay-Patchers-Community/liferay-portal/archive/6.1.1-ga2-patched.zip

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks for your help Troy,

But probably the best option should be to stick with the git branch.

Thanks again!

[Troy Griffitts, geändert vor 11 Jahren.]

Thanks Juan,

I will stick the with git branch, but just to be clear, I intented to say in my last message that the git branch does not build for me.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ups, sorry didn't understand.

Ok will check the errors at github branch this evening.

Probably I didn't pushed that changed file.

Thanks.

[Luis Mas, geändert vor 11 Jahren.]

Juan, I had the same problem that Troy told you (just to confirm you):

compile:
[mkdir] Created dir: c:\lcepath611\6.1.1patched\portal\portal-service\classes
[copy] Copying 15 files to c:\lcepath611\6.1.1patched\portal\portal-service\classes
[copy] Copied 304 empty directories to 282 empty directories under c:\lcepath611\6.1.1patched\portal\portal-service\classes
[javac] Compiling 3982 source files to c:\lcepath611\6.1.1patched\portal\portal-service\classes
[javac] ----------
[javac] 1. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 179)
[javac] List<FileEntry> fileEntries = _baseRepository.getFileEntries(
[javac] folderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 2. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 190)
[javac] List<FileEntry> fileEntries = _baseRepository.getFileEntries(
[javac] folderId, documentTypeId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 3. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 211)
[javac] List<Object> objects = _baseRepository.getFileEntriesAndFileShortcuts(
[javac] folderId, status, start, end);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 4. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 313)
[javac] _baseRepository.getFoldersAndFileEntriesAndFileShortcuts(
[javac] folderId, status, includeMountFolders, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 5. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 337)
[javac] return _baseRepository.getFoldersAndFileEntriesAndFileShortcutsCount(
[javac] folderId, status, includeMountFolders);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 6. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 373)
[javac] List<Folder> folders = _baseRepository.getMountFolders(
[javac] parentFolderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 7. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 394)
[javac] List<FileEntry> fileEntries = _baseRepository.getRepositoryFileEntries(
[javac] userId, rootFolderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 8. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 414)
[javac] return _baseRepository.getRepositoryFileEntriesCount(
[javac] userId, rootFolderId);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 9. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 433)
[javac] _baseRepository.getSubfolderIds(folderIds, folderId);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 10. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\BaseRepositoryProxyBean.java (at line 439)
[javac] return _baseRepository.getSubfolderIds(folderId, recurse);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] ----------
[javac] 11. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\LocalRepositoryProxyBean.java (at line 102)
[javac] List<FileEntry> fileEntries = _localRepository.getFileEntries(
[javac] folderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 12. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\LocalRepositoryProxyBean.java (at line 112)
[javac] List<Object> objects = _localRepository.getFileEntriesAndFileShortcuts(
[javac] folderId, status, start, end);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 13. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\LocalRepositoryProxyBean.java (at line 193)
[javac] _localRepository.getFoldersAndFileEntriesAndFileShortcuts(
[javac] folderId, status, includeMountFolders, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 14. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\LocalRepositoryProxyBean.java (at line 217)
[javac] return _localRepository.getFoldersAndFileEntriesAndFileShortcutsCount(
[javac] folderId, status, includeMountFolders);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 15. ERROR in c:\lcepath611\6.1.1patched\portal\portal-service\src\com\liferay\portal\repository\proxy\LocalRepositoryProxyBean.java (at line 247)
[javac] List<Folder> folderList = _localRepository.getMountFolders(
[javac] parentFolderId, start, end, obc);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type PortalException
[javac] ----------
[javac] 15 problems (15 errors)

I tried to build from Windows.

Regards, Luis

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok pushed the file.

Please fetch latest changes and re-compile...

[Juan Gonzalez P, geändert vor 11 Jahren.]

Sorry!! They were two files. Now pushed to github.

Just git pull the latest changes and you should compile now.

[Fuad Efendi, geändert vor 11 Jahren.]

I have problems similar to that:

[javac] 1. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portal/deploy/hot/ServletContextListenerHotDeployListener.java (at line 66)
[javac] securePluginContextListener.instantiatingListeners();
[javac] ^^^^^^^^^^^^^^^^^^^^^^
[javac] The method instantiatingListeners() from the type SecurePluginContextListener is not visible


Using latest code from https://github.com/Liferay-Patchers-Community/liferay-portal/tree/6.1.1-ga2-patched

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok, pushed another missing file.

Please pull and re-try

[Fuad Efendi, geändert vor 11 Jahren.]

Yes thanks... less problems now, but still:



compile-java:
[javac] Compiling 6 source files to /java/git/liferay-portal-patched/portal-impl/classes
[javac] ----------
[javac] 1. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portal/spring/context/PortalContextLoaderListener.java (at line 146)
[javac] DBFactoryUtil.reset();
[javac] ^^^^^
[javac] The method reset() is undefined for the type DBFactoryUtil
[javac] ----------
[javac] 2. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portal/spring/context/PortalContextLoaderListener.java (at line 147)
[javac] DeployManagerUtil.reset();
[javac] ^^^^^
[javac] The method reset() is undefined for the type DeployManagerUtil
[javac] ----------
[javac] 3. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portal/spring/context/PortalContextLoaderListener.java (at line 151)
[javac] PortalLifecycleUtil.reset();
[javac] ^^^^^
[javac] The method reset() is undefined for the type PortalLifecycleUtil
[javac] ----------
[javac] ----------
[javac] 4. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/documentlibrary/service/impl/DLFileEntryServiceImpl.java (at line 394)
[javac] folderIds = DLAppUtil.filterFolderIds(
[javac] ^^^^^^^^^^^^^^^
[javac] The method filterFolderIds(PermissionChecker, long, long[]) is undefined for the type DLAppUtil
[javac] ----------
[javac] 5. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/documentlibrary/service/impl/DLFileEntryServiceImpl.java (at line 417)
[javac] folderIds = DLAppUtil.filterFolderIds(
[javac] ^^^^^^^^^^^^^^^
[javac] The method filterFolderIds(PermissionChecker, long, long[]) is undefined for the type DLAppUtil
[javac] ----------
[javac] ----------
[javac] 6. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/documentlibrary/store/AdvancedFileSystemStore.java (at line 66)
[javac] super.updateFile(companyId, repositoryId, fileName, newFileName);
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] Unhandled exception type SystemException
[javac] ----------
[javac] ----------
[javac] 7. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/documentlibrary/store/DLStoreImpl.java (at line 543)
[javac] if (fileName.endsWith(TempFileUtil.SUFFIX_TEMP_FILE_NAME)) {
[javac] ^^^^^^^^^^^^^^^^^^^^^
[javac] SUFFIX_TEMP_FILE_NAME cannot be resolved or is not a field
[javac] ----------
[javac] 8. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/documentlibrary/store/DLStoreImpl.java (at line 545)
[javac] fileName, TempFileUtil.SUFFIX_TEMP_FILE_NAME, StringPool.BLANK);
[javac] ^^^^^^^^^^^^^^^^^^^^^
[javac] SUFFIX_TEMP_FILE_NAME cannot be resolved or is not a field
[javac] ----------
[javac] ----------
[javac] 9. ERROR in /java/git/liferay-portal-patched/portal-impl/src/com/liferay/portlet/rss/lar/RSSPortletDataHandlerImpl.java (at line 242)
[javac] JournalPortletDataHandlerImpl.exportArticle(
[javac] ^^^^^^^^^^^^^
[javac] The method exportArticle(PortletDataContext, Element, Element, Element, Element, Element, Element, Element, Element, Element, JournalArticle, boolean) in the type JournalPortletDataHandlerImpl is not applicable for the arguments (PortletDataContext, Element, Element, Element, Element, Element, Element, Element, Element, Element, JournalArticle, null, boolean)
[javac] ----------
[javac] 9 problems (9 errors)

[Juan Gonzalez P, geändert vor 11 Jahren.]

Thanks for your help.

Because of line breaks I didn't want to upload all files (perhaps I should have to).

Uploaded only those files.

Please retry.

[Fuad Efendi, geändert vor 11 Jahren.]

BUILD SUCCESSFUL


Thank you!!!!!!!!!!!!!!!!!!

[Fuad Efendi, geändert vor 11 Jahren.]

And I am using Mac OS X Lion, with "Tower" GitHub client.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Juan, we have to download the version that is in github (https://github.com/Liferay-Patchers-Community/liferay-portal) and the patched from file? or just the patched file?
Thanks

[Juan Gonzalez P, geändert vor 11 Jahren.]

Ok I've removed CRLF (using fromdos utility) of all files.

Now all files are commited, so it's supposed to be exactly the same version as I have.

So please test it and give your feedback.

You can download from this github branch:

https://github.com/Liferay-Patchers-Community/liferay-portal/tree/6.1.1-ga2-patched

Thanks for your help!

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

I get this error Juan:
git clone https://github.com/Liferay-Patchers-Community/liferay-portal/tree/6.1.1-ga2-patched
Cloning into '6.1.1-ga2-patched'...
fatal: https://github.com/Liferay-Patchers-Community/liferay-portal/tree/6.1.1-ga2-patched/info/refs not found: did you run git update-server-info on the server

[Luis Mas, geändert vor 11 Jahren.]

Build successfull in Windows 8. Steps I followed:

[indent]1. In Windows create this structure:
[indent]C:\lcepatch611\6.1.1patched
C:\lcepatch611\6.1.1patched\bundles[/indent]
2. Copy in bundles a Liferay 6.1.1. CE bundled with tomcat:
[indent]C:\lcepatch611\6.1.1patched\bundles\data
C:\lcepatch611\6.1.1patched\bundles\license
C:\lcepatch611\6.1.1patched\bundles\tomcat-7.0.27[/indent]
3. In gitbash:
[indent]$cd /c/lcepatch611/6.1.1patched
$git clone -b 6.1.1-ga2-patched [e-mail]:/Liferay-Patchers-Community/liferay-portal portal
$cd portal[/indent]
4. Build Liferay:
$[indent][/indent]ant all
[/indent]

...
BUILD SUCCESSFUL
Total time: 10 minutes 9 seconds

I'll try later in Ubuntu 12.10 and let you now if it was succesful.

Juan, you're a crack.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

can't clone the branch, I could with liferay-portal, but when trying the branch gives this error:

Ubuntu 12.04


git 'clone' '-b' '6.1.1-ga2-patched' '[e-mail]:/Liferay-Patchers-Community/liferay-portal' 'portal'
Cloning into 'portal'...
trace: run_command: 'ssh' '[e-mail]' 'git-upload-pack '\''/Liferay-Patchers-Community/liferay-portal'\'''
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

[Luis Mas, geändert vor 11 Jahren.]

Gabriel Leon Leyva:

can't clone the branch, I could with liferay-portal, but when trying the branch gives this error:

Ubuntu 12.04


git 'clone' '-b' '6.1.1-ga2-patched' '[e-mail]:/Liferay-Patchers-Community/liferay-portal' 'portal'
Cloning into 'portal'...
trace: run_command: 'ssh' '[e-mail]' 'git-upload-pack '\''/Liferay-Patchers-Community/liferay-portal'\'''
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

I think you have an issue with your key: http://www.celticwolf.com/blog/2011/02/08/git-permission-denied-publickey/

[Juan Gonzalez P, geändert vor 11 Jahren.]

Try this:

git clone -b 6.1.1-ga2-patched https://github.com/Liferay-Patchers-Community/liferay-portal.git

[Denis Signoretto, geändert vor 11 Jahren.]

Hi Jonas,

just a couple of questions:

- Liferay Pachers Community Project include security fix made by Liferay Community Team https://github.com/community-security-team/ ?
- Do you already considered to keep a tag or and a Release Note that track list of included patches?

Many thanks,
Denis.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Jonas? Who 's Jonas?

Yep, there are some fixes from there (if not all of them).

You have the fixed issues in lcepatchers.org web site.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Thanks Juan :=)

[JB Burbea, geändert vor 11 Jahren.]

Hi Luis / Juan,

I followed Luis steps. Although you don't need to copy an old tomcat LR bundle download to the C:\lcepatch611\6.1.1patched\bundles\ directory.

If you run ant all from the C:\lcepatch611\6.1.1patched\portal source. The run:

ant -buildfile build-dist.xml unzip-tomcat

And the bundle will be built.

My concern is that when I do Juan / Luis build I for dists:
ant -buildfile build-dist.xml zip-portal-war
ant -buildfile build-dist.xml zip-portal-dependencies

I end up with dists called:
liferay-portal-6.1.0.war
liferay-portal-dependencies-6.1.0.zip

Why not dists called:
liferay-portal-6.1.1-ga2-patched-XXXX.war or .zip

It is confusing that my standalones and dependencies are called 6.1 not 6.1.1 GA2?

Thanks,
JB

[Henrique Simoes de Andrade, geändert vor 11 Jahren.]

Hi!
This patch resolved my "invalid ALTER TABLE option" problem in Oracle.
Thank you very much!

[Juan Gonzalez P, geändert vor 11 Jahren.]

Good to hear that

[Juan Gonzalez P, geändert vor 11 Jahren.]

I need your help again.

I've noticed an error when starting portal with some plugins, themes, etc in glassfish server. Seems that themes and plugins (for example kaleo-web) aren't deployed when starting the server.

Rolling back changes made by this issue:

LPS-30243 Portal can't be restarted in Weblogic app server (and probably others)

seems to solve it.

Can you reproduce the problem in your environments?

Thanks

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

I still can't compile get this error:
build-common-java.compile:

compile-java:
[copy] Copying 2 files to /home/work/trunk/portal-impl/classes
[javac] Compiling 3951 source files to /home/work/trunk/portal-impl/classes
[javac] ----------
[javac] 1. ERROR in /home/work/trunk/portal-impl/src/com/liferay/portal/json webservice/JSONWebServiceConfigurator.java (at line 196)
[javac] classReader.accept(jsonWebServiceClassVisitor, 0);
[javac] ^^^^^^
[javac] The method accept(ClassVisitor, boolean) in the type ClassReader is not applicable for the arguments (JSONWebServiceClassVisitor, int)
[javac] ----------
[javac] 1 problem (1 error)

BUILD FAILED

[Juan Gonzalez P, geändert vor 11 Jahren.]

Gabriel,

You've to do the same as Luis said before.

Thanks

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

I commented those lines and know can compile and it's working fine, I don't use yet JasonWebServices anyways.

[Abc Defg, geändert vor 11 Jahren.]

Juan, job well done.
What I do not understand is why is Liferay still pushing unpatched 6.1.1 GA2 (and bundle) on his download site.
That makes absolutely no sense at all.

[Juan Gonzalez P, geändert vor 11 Jahren.]

Don't agree. It makes all sense. Liferay CE doesn't have patches. If you want official patches, go for EE version.

[Abc Defg, geändert vor 11 Jahren.]

Juan Gonzalez P:

Don't agree. It makes all sense. Liferay CE doesn't have patches. If you want official patches, go for EE version.

How is this making any sense to you? Can you elaborate? Do you really think that letting people download a half baked product, that needs serious patching (and has patches ready and available at the same time!) is OK? Really?
We use CE for serious stuff and not for some toy projects to "test it out". Sadly, we are stuck with CE and Liferay and there is nothing we can do about it.

[Juan Gonzalez P, geändert vor 11 Jahren.]

I use CE for serious stuff too. If you want support, you know you have to get EE license. If not, learn about J2EE and patching, that's open source.

You have source code and commits in github, it's up to you.

And absolutely don't agree about "half baked" product. 6.1.1 isn't like that.

[Juan Gonzalez P, geändert vor 11 Jahren.]

FYI seems it will be another 6.1 GA release soon.

[Abc Defg, geändert vor 11 Jahren.]

Juan Gonzalez P:

FYI seems it will be another 6.1 GA release soon.

I have used FOSS for ages (over 10 years in actual work environment) and serious projects usually have some type of release schedules published, so the rest of the world (like us, the users) can plan their updates, developments, migrations etc.
Where can I find the release schedule for liferay CE?
PS! Do not tell me again to f** off and use EE ;) This joke is getting old.

[Juan Gonzalez P, geändert vor 11 Jahren.]

You can find that info in

issues.liferay.com

And recently there is another approach:

http://www.liferay.com/community/releases

[Denis Signoretto, geändert vor 11 Jahren.]

Hi Juan,

this new page it's really interesting. Do you know if there is the possibility to subscribe it (like in blogs, message boards, ecc) ?

Regards.
Denis

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi Denis,

Seems that there is an RSS link in bottom of that content. This is the RSS link:

http://www.liferay.com/community/releases/-/asset_publisher/nSr2/rss?p_p_cacheability=cacheLevelPage

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

Hi Juan LPS-25524 thanks in advance :-)

[Juan Gonzalez P, geändert vor 11 Jahren.]

Hi Gabriel,

That issue is already solved in 6.1.1 GA2.

[Gabriel Leon Leyva, geändert vor 11 Jahren.]

I was getting this error when compiling:

[javac] getClassLoader(), listenerClassName));
[javac] ^^^^^^^^^^^^^^
[javac] The method getClassLoader() is undefined for the type UserThreadPersistenceImpl

but with a build-service the error is gone... sorry for that.

Thanks have a nice day.

[James Falkner, geändert vor 11 Jahren.]

Denis Signoretto:

Hi Juan,

this new page it's really interesting. Do you know if there is the possibility to subscribe it (like in blogs, message boards, ecc) ?

Regards.
Denis

Hey Denis et al, I go into some detail about the need for such a page in this blog post, and yes, we are planning a GA3 release in the next 2 months (hopefully sooner), as can be seen on that release dashboard. Also, the project leads tend to announce releases in other places as well, such as the recent release of Liferay Faces 3.1.1.

[Chris H, geändert vor 11 Jahren.]

For those using Postgres, there is an error with bookmarks and folders (LPS-29559 in 6.1.x).

[Luis Mas, geändert vor 11 Jahren.]

Abc Defg:

Juan Gonzalez P:

FYI seems it will be another 6.1 GA release soon.

I have used FOSS for ages (over 10 years in actual work environment) and serious projects usually have some type of release schedules published, so the rest of the world (like us, the users) can plan their updates, developments, migrations etc.
Where can I find the release schedule for liferay CE?
PS! Do not tell me again to f** off and use EE ;) This joke is getting old.

Dear ABC DEFG (what's your name?),

First of all, Liferay is Open Source, not full FOSS. All the FOSS projects you know have a business model different from the Liferay one, that is more similar to Alfresco and many others.

As Liferay had this weakness, the comunity started a project to have a better release schedule for Liferay CE and you can find it here www.lcepatchers.org (is still starting). The main contributor is Juan, and you are welcome.

Regards, Luis

[Hitoshi Ozawa, geändert vor 11 Jahren.]

Release schedule is one of the weakest point of Liferay.
As others have pointed out, Liferay is not a FOSS but a COSS.

Release schedule of EE is related to CE release dates so switching to EE won't make scheduling easier.

If you read the Gartner's evaluation on weakness of Liferay, I think you'll have to agree with them.

(to the right of the page)
http://www.liferay.com/home

That said, I think most of us are very sick of hearing about liferay schedule and quality because this is a very dead topic - liferay.com is
not going to change (period).

I think most of us here on this thread is trying to do something about it because we think liferay is fundamentally a very good software.