Fórumok
Localization of lang.line.begin and lang.line.end
Milan Jaroš, módosítva 10 év-val korábban
Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Howdy!
I'd like to be really sure what is the purpose of lang.line.begin and lang.line.end. I'm pretty sure that lang.dir should not be "translated" but "specified" to ltr or rtl.
What about lang.line.begin and lang.line.end? Can it contain only values like left and right?
I'd like to be really sure what is the purpose of lang.line.begin and lang.line.end. I'm pretty sure that lang.dir should not be "translated" but "specified" to ltr or rtl.
What about lang.line.begin and lang.line.end? Can it contain only values like left and right?
Olaf Kock, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Liferay Legend Bejegyzések: 6403 Csatlakozás dátuma: 2008.09.23. Legújabb bejegyzésekMilan Jaroš:
What about lang.line.begin and lang.line.end? Can it contain only values like left and right?
Hi Milan,
I assume you're right - however, the only use of "lang.line.begin" that I've found is in LangBuilder - and there it's only providing a default value. I did not even find any use of "lang.line" so I'll assume for now that this is never used anywhere in the portal. I didn't search the plugins, and I might have missed it, but searching for "left" also didn't reveal anything that seemed relevant (though at least there are lots of hits for "left" - can't say I'm right on this)
Given the way LangBuilder handles the default values, I assume it's safe to assume that "lang.line.begin" was expected to be "left" or "right". And maybe it still is, maybe it's a relict of the past. Maybe someone who can make sense of RTL languages can try if there's an unexpected side effect if "left" and "right" are exchanged for those languages? Or just try it out in english/czech or another LTR language.
Not to mention that I'm curious to see if someone corrects me and points me to the place I've been missing where it's indeed used.
Daniel Sanz, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Regular Member Bejegyzések: 143 Csatlakozás dátuma: 2010.12.14. Legújabb bejegyzések
Hi guys,
what I can tell you about this is that I explicitly override any translation provided via Pootle for those 3 keys. I implemented such a mechanism in the sync scripts because prior to that I had to manually "revert" back those keys for all languages to their corresponding values (rtl, ltr, etc).
I think that RTL support is being improved right now here in Spanish office, I'll ask our guys for the lang.line.* usages.
Thanks,
what I can tell you about this is that I explicitly override any translation provided via Pootle for those 3 keys. I implemented such a mechanism in the sync scripts because prior to that I had to manually "revert" back those keys for all languages to their corresponding values (rtl, ltr, etc).
I think that RTL support is being improved right now here in Spanish office, I'll ask our guys for the lang.line.* usages.
Thanks,
Milan Jaroš, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Ok, thanks, good luck. ;)
Milan Jaroš, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Any news?
Milan Jaroš, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Bump. ;)
Daniel Sanz, módosítva 9 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Regular Member Bejegyzések: 143 Csatlakozás dátuma: 2010.12.14. Legújabb bejegyzések
Hi,
I talked to one of the developers of RTL support and he thinks that properties are no longer used, but he's not 100% sure.
Since it seems that it won't be easy to find someone who solves the mistery, I decided to do some code archaeology and look for its origins.
I developed a small script that connects to our SVN server and checks each single commit difference to see if contains the interesting stuff. I had to use SVN as changes are pre-git. This will lead us to a set of revisions which could later check. I'm trying with portal repo so far (assuming that plugins don'r make use of them)
The process is not particularly quick, so I can't offer remarkable results so far...
I'll update the thread when more info is available.
Cheers
I talked to one of the developers of RTL support and he thinks that properties are no longer used, but he's not 100% sure.
Since it seems that it won't be easy to find someone who solves the mistery, I decided to do some code archaeology and look for its origins.
I developed a small script that connects to our SVN server and checks each single commit difference to see if contains the interesting stuff. I had to use SVN as changes are pre-git. This will lead us to a set of revisions which could later check. I'm trying with portal repo so far (assuming that plugins don'r make use of them)
The process is not particularly quick, so I can't offer remarkable results so far...
I'll update the thread when more info is available.
Cheers
Milan Jaroš, módosítva 9 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Hi, that sounds promising. Thanks! Maybe it could be completely removed. We will see.
I'm lucky man that I use TFS, there is such feature out-of-the-box... Behold!
I'm lucky man that I use TFS, there is such feature out-of-the-box... Behold!
Milan Jaroš, módosítva 10 év-val korábban
RE: Localization of lang.line.begin and lang.line.end
Expert Bejegyzések: 268 Csatlakozás dátuma: 2008.08.18. Legújabb bejegyzések
Hi Olaf,
thank you for digging and your effort.
thank you for digging and your effort.