Le mie Attività

aprile 1
Tim Telcik ha aggiornato LPS-45578.
Tim Telcik ha aggiornato LPS-45578.
marzo 25
Tim Telcik ha lasciato un commento su LPS-39618.
febbraio 24
Tim Telcik ha lasciato un commento su LPS-29634.
febbraio 12
Tim Telcik ha lasciato un commento su LPS-43671.
febbraio 11
Tim Telcik ha lasciato un commento su LPS-43671.
18.24 Hello Jenny, I have been watching this ticket and notice your comment above, posted on 12/Feb/14 12:26 AM at [https://issues.liferay.com/browse/LPS-43671?focusedCommentId=416041&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-416041] How can it be expected behaviour for the build to success when the SASS to CSS compiler fails during the build for a theme plugin ? This results in invalid CSS files packaged with the theme plugin and goes undetected until the theme is deployed to an instance of Liferay Portal. This false-positive approach is an issue when building themes using Ant or Maven. From my investigation, the cause of this issue may be in class com.liferay.portal.tools.SassToCssBuilder between line 256 - 260 as follows: {code} catch (Exception e) { System.out.println("Unable to parse " + fileName); e.printStackTrace(); } {code} This snippet contains a catch clause for a generic Exception, which is handled by simply printing a stack trace. The exception is printed to standard output, but is not propagated to the Ant or Maven build tools. The exception clause appears in context between lines 216 - 262 as follows : {code} package com.liferay.portal.tools; public class SassToCssBuilder { private void _parseSassDirectory( String dirName, String docrootDirName, String portalCommonDirName) throws Exception { /* code removed for clarity */ {code} One possible solution is replacing this code block {code} catch (Exception e) { System.out.println("Unable to parse " + fileName); e.printStackTrace(); } {code} with this code block {code} catch (Exception e) { String msg = "Unable to parse " + fileName + “ : “ + e.getMessage(); System.out.println(msg); e.printStackTrace(); throw new Exception(msg,e); } {code} which should trigger the Ant or Maven build to fail, as expected. Please review and advise. Regards, Tim
Inscriviti alle attività di Tim Telcik. (Apri una nuova finestra)