Activities

May 11
Alain Dresse replied to Sunil Kulkarni's message board post, RE: Unable to add new method in XXXPersistenceImpl class, in Liferay.com.
10:36 AM Go to Category
April 30
9:10 AM Go to Category
April 22
eastor liu replied to Alain Dresse's message board post, RE: Filter and Refine contents based on multiple categories?, in Liferay.com.
1:12 AM Go to Category
March 25
Hitoshi Ozawa replied to Alain Dresse's message board post, RE: Upgrade CKEditor to 4.x, in Liferay.com.
3:34 PM Go to Category
Alain Dresse replied to Juan Fernández's message board post, RE: Upgrade CKEditor to 4.x, in Liferay.com.
1:44 PM Go to Category
March 20
Mayur Patel and Alain Dresse are now friends.
6:17 PM
mukesh kumar and Alain Dresse are now friends.
6:17 PM
Durgadas Menon and Alain Dresse are now friends.
6:17 PM
March 13
Alain Dresse commented on LPS-27424.
3:41 AM Aniceto, Unfortunately, I cannot test on 6.2.0m4 (a bit short on time with a release of my platform on Monday... in a one person company). I did a quick check in the code on github however, and I am pretty confident the issue still exists: permissions for comments (i.e. discussions) relate to the item being commented, and not the asset itself, as can be seen from the MBMessageAssetRenderer.hasViewPermission ([see here on github|https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/messageboards/asset/MBMessageAssetRenderer.java]) : {code:title=MBMessageAssetRenderer.java extract|borderStyle=solid} @Override public boolean hasViewPermission(PermissionChecker permissionChecker) throws PortalException, SystemException { if (_message.isDiscussion()) { return MBDiscussionPermission.contains( permissionChecker, _message.getCompanyId(), _message.getGroupId(), _message.getClassName(), _message.getClassPK(), _message.getMessageId(), _message.getUserId(), ActionKeys.VIEW); } else { return MBMessagePermission.contains( permissionChecker, _message, ActionKeys.VIEW); } } {code} The filtering method in [AssetEntryServiceImpl.java|https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/asset/service/impl/AssetEntryServiceImpl.java] {code:title=AssetEntryServiceImpl.java extract|borderStyle=solid} if (assetRendererFactory.hasPermission( permissionChecker, classPK, ActionKeys.VIEW)) { filteredEntries.add(entry); } {code} checks the permissions of the asset entry, (i.e. the MBDiscussion), not the item being commented. Unless those permissions are synchronized the bug is not solved. Best regards, Alain
Alain Dresse commented on LPS-27561.
Subscribe to Alain Dresse's activities. (Opens New Window)