All commits on svn://svn.liferay.com/repos/public/portal/trunk. All commits on svn://svn.liferay.com/repos/public/portal/trunk. Revision 154299 Mika Koivisto 2013-06-18T06:15:29Z 2013-06-18T06:15:29Z LPS-36391 As a developer it would be nice to remove the never used, never documented feature Renderer Mika Koivisto 2013-06-18T06:15:29Z Revision 154298 Mika Koivisto 2013-06-18T06:15:28Z 2013-06-18T06:15:28Z LPS-36376 Source formatting Mika Koivisto 2013-06-18T06:15:28Z Revision 154297 Mika Koivisto 2013-06-18T06:15:26Z 2013-06-18T06:15:26Z LPS-36376 I only chain in very specific places, like *Util (see LanguageUtil). Otherwise, I try to avoid it if possible. Mika Koivisto 2013-06-18T06:15:26Z Revision 154296 Mika Koivisto 2013-06-18T06:15:20Z 2013-06-18T06:15:20Z LPS-35671 Lang keys Mika Koivisto 2013-06-18T06:15:20Z Revision 154295 Mika Koivisto 2013-06-18T06:15:18Z 2013-06-18T06:15:18Z LPS-35671 Text Mika Koivisto 2013-06-18T06:15:18Z Revision 154294 Mika Koivisto 2013-06-18T06:15:15Z 2013-06-18T06:15:15Z LPS-35671 SF Mika Koivisto 2013-06-18T06:15:15Z Revision 154293 Mika Koivisto 2013-06-18T06:15:14Z 2013-06-18T06:15:14Z LPS-35671 Sort some of it? Mika Koivisto 2013-06-18T06:15:14Z Revision 154292 Mika Koivisto 2013-06-18T06:15:13Z 2013-06-18T06:15:13Z LPS-35671 Remove unused import Mika Koivisto 2013-06-18T06:15:13Z Revision 154291 Mika Koivisto 2013-06-18T06:15:11Z 2013-06-18T06:15:11Z LPS-35671 See notes in WebKeys#LIFERAY_SHARED_VISITED_GROUP_ID_RECENT Mika Koivisto 2013-06-18T06:15:11Z Revision 154290 Mika Koivisto 2013-06-18T06:15:10Z 2013-06-18T06:15:10Z LPS-35671 Use the portal message to show alternative url to the user when he is redirected because the locale didn't match the localized friendly url Mika Koivisto 2013-06-18T06:15:10Z Revision 154289 Mika Koivisto 2013-06-18T06:15:09Z 2013-06-18T06:15:09Z LPS-35937 Store the information in PortalMessages as a shared attribute so it can be used from external plugins. The message is added to top_messages.jsp Mika Koivisto 2013-06-18T06:15:09Z Revision 154288 Mika Koivisto 2013-06-18T06:15:08Z 2013-06-18T06:15:08Z LPS-35937 Create PortalMessages.java from SessionErrors.java Mika Koivisto 2013-06-18T06:15:08Z Revision 154287 Mika Koivisto 2013-06-18T06:15:07Z 2013-06-18T06:15:07Z LPS-35937 - Source formatting Mika Koivisto 2013-06-18T06:15:07Z Revision 154286 Mika Koivisto 2013-06-18T06:15:06Z 2013-06-18T06:15:06Z LPS-35937 - Improve Notice component so it will be able to close automatically on given timeout Mika Koivisto 2013-06-18T06:15:06Z Revision 154285 Mika Koivisto 2013-06-18T06:15:04Z 2013-06-18T06:15:04Z LPS-36376 Since it's public, no _ Mika Koivisto 2013-06-18T06:15:04Z Revision 154284 Mika Koivisto 2013-06-18T06:15:01Z 2013-06-18T06:15:01Z LPS-36376 Only calculate portalSource once Mika Koivisto 2013-06-18T06:15:01Z Revision 154283 Mika Koivisto 2013-06-18T06:14:52Z 2013-06-18T06:14:52Z LPS-36376 Sort Mika Koivisto 2013-06-18T06:14:52Z Revision 154282 Mika Koivisto 2013-06-18T06:14:50Z 2013-06-18T06:14:50Z LPS-36376 Make protected methods in BaseSourceProcessor non-abstract Mika Koivisto 2013-06-18T06:14:50Z Revision 154281 Mika Koivisto 2013-06-18T06:14:49Z 2013-06-18T06:14:49Z LPS-36376 Skip *SourceProcessor.java files Mika Koivisto 2013-06-18T06:14:49Z Revision 154280 Mika Koivisto 2013-06-18T06:14:47Z 2013-06-18T06:14:47Z LPS-36376 Source formatting Mika Koivisto 2013-06-18T06:14:47Z Revision 154279 Mika Koivisto 2013-06-18T06:14:46Z 2013-06-18T06:14:46Z LPS-36376 Refactor SourceFormatter - Move code to JavaSourceProcessor Mika Koivisto 2013-06-18T06:14:46Z Revision 154278 Mika Koivisto 2013-06-18T06:14:45Z 2013-06-18T06:14:45Z LPS-36376 Refactor SourceFormatter - Move code to JSPSourceProcessor Mika Koivisto 2013-06-18T06:14:45Z Revision 154277 Mika Koivisto 2013-06-18T06:14:43Z 2013-06-18T06:14:43Z LPS-36376 Refactor SourceFormatter - Move code to XMLSourceProcessor Mika Koivisto 2013-06-18T06:14:43Z Revision 154276 Mika Koivisto 2013-06-18T06:14:42Z 2013-06-18T06:14:42Z LPS-36376 Refactor SourceFormatter - Move code to TLDSourceProcessor Mika Koivisto 2013-06-18T06:14:42Z Revision 154275 Mika Koivisto 2013-06-18T06:14:41Z 2013-06-18T06:14:41Z LPS-36376 Refactor SourceFormatter - Move code to SQLSourceProcessor Mika Koivisto 2013-06-18T06:14:41Z Revision 154274 Mika Koivisto 2013-06-18T06:14:40Z 2013-06-18T06:14:40Z LPS-36376 Refactor SourceFormatter - Move code to SHSourceProcessor Mika Koivisto 2013-06-18T06:14:40Z Revision 154273 Mika Koivisto 2013-06-18T06:14:38Z 2013-06-18T06:14:38Z LPS-36376 Refactor SourceFormatter - Move code to PropertiesSourceProcessor Mika Koivisto 2013-06-18T06:14:38Z Revision 154272 Mika Koivisto 2013-06-18T06:14:37Z 2013-06-18T06:14:37Z LPS-36376 Refactor SourceFormatter - Move code to JSSourceProcessor Mika Koivisto 2013-06-18T06:14:37Z Revision 154271 Mika Koivisto 2013-06-18T06:14:35Z 2013-06-18T06:14:35Z LPS-36376 Refactor SourceFormatter - Move code to FTLSourceProcessor Mika Koivisto 2013-06-18T06:14:35Z Revision 154270 Mika Koivisto 2013-06-18T06:14:34Z 2013-06-18T06:14:34Z LPS-36376 Add methods Mika Koivisto 2013-06-18T06:14:34Z Revision 154269 Mika Koivisto 2013-06-18T06:14:31Z 2013-06-18T06:14:31Z LPS-36376 Sort Mika Koivisto 2013-06-18T06:14:31Z Revision 154268 Mika Koivisto 2013-06-18T06:14:30Z 2013-06-18T06:14:30Z LPS-36376 Make methods that will be called from subclasses protected Mika Koivisto 2013-06-18T06:14:30Z Revision 154267 Mika Koivisto 2013-06-18T06:14:29Z 2013-06-18T06:14:29Z LPS-35322 SF Mika Koivisto 2013-06-18T06:14:29Z Revision 154266 Mika Koivisto 2013-06-18T06:14:28Z 2013-06-18T06:14:28Z LPS-35322 SF Mika Koivisto 2013-06-18T06:14:28Z Revision 154265 Mika Koivisto 2013-06-18T06:14:26Z 2013-06-18T06:14:26Z LPS-35322 replaced case removed by LPS-31496 Mika Koivisto 2013-06-18T06:14:26Z Revision 154264 Mika Koivisto 2013-06-18T06:14:25Z 2013-06-18T06:14:25Z LPS-36384 - Source formatting From: Nate Cavanaugh <nate@shift22.com> Mika Koivisto 2013-06-18T06:14:25Z Revision 154263 Mika Koivisto 2013-06-18T06:14:24Z 2013-06-18T06:14:24Z LPS-36384 - JS error when adding comments Mika Koivisto 2013-06-18T06:14:24Z Revision 154262 Mika Koivisto 2013-06-18T06:14:22Z 2013-06-18T06:14:22Z LPS-36341 - Source Format Javascript function calls Mika Koivisto 2013-06-18T06:14:22Z Revision 154261 Mika Koivisto 2013-06-18T06:14:21Z 2013-06-18T06:14:21Z LPS-36045 - tests Mika Koivisto 2013-06-18T06:14:21Z Revision 154260 Mika Koivisto 2013-06-18T06:14:18Z 2013-06-18T06:14:18Z LPS-36045 - tests Mika Koivisto 2013-06-18T06:14:18Z Revision 154259 Mika Koivisto 2013-06-18T06:14:16Z 2013-06-18T06:14:16Z LPS-36045 - macros Mika Koivisto 2013-06-18T06:14:16Z Revision 154256 Mika Koivisto 2013-06-18T06:14:15Z 2013-06-18T06:14:15Z LPS-36045 - functions Mika Koivisto 2013-06-18T06:14:15Z Revision 154255 Mika Koivisto 2013-06-18T06:14:13Z 2013-06-18T06:14:13Z LPS-36045 - actions Mika Koivisto 2013-06-18T06:14:13Z Revision 154253 Mika Koivisto 2013-06-18T06:14:11Z 2013-06-18T06:14:11Z LPS-36045 - paths Mika Koivisto 2013-06-18T06:14:11Z Revision 154252 Mika Koivisto 2013-06-18T06:14:10Z 2013-06-18T06:14:10Z SF<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154252"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:14:10Z Revision 154251 Mika Koivisto 2013-06-18T06:14:07Z 2013-06-18T06:14:07Z SF<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154251"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:14:07Z Revision 154250 Mika Koivisto 2013-06-18T06:14:04Z 2013-06-18T06:14:04Z SF<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154250"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:14:04Z Revision 154249 Mika Koivisto 2013-06-18T06:14:01Z 2013-06-18T06:14:01Z Remove sample.sql.asset.publisher.config.filter<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154249"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:14:01Z Revision 154248 Mika Koivisto 2013-06-18T06:13:57Z 2013-06-18T06:13:57Z Change the 2 dimensions arrays to List<?>[] to avoid unnecessary temporary lists.<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154248"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:13:57Z Revision 154247 Mika Koivisto 2013-06-18T06:13:55Z 2013-06-18T06:13:55Z Config filter for Asset Publisher<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154247"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:13:55Z Revision 154246 Mika Koivisto 2013-06-18T06:13:52Z 2013-06-18T06:13:52Z Add properties for asset publisher to benchmark.properties.<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154246"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:13:52Z Revision 154245 Mika Koivisto 2013-06-18T06:13:50Z 2013-06-18T06:13:50Z Use array instead of List to make the code easy to read.<br />Modify SampleSQLBuilder to generate data for AssetPublisher test.<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154245"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34467"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:13:50Z Revision 154244 Mika Koivisto 2013-06-18T06:13:45Z 2013-06-18T06:13:45Z LPS-36032 Lang keys Mika Koivisto 2013-06-18T06:13:45Z Revision 154243 Mika Koivisto 2013-06-18T06:13:42Z 2013-06-18T06:13:42Z LPS-36032 Forgot to update key Mika Koivisto 2013-06-18T06:13:42Z Revision 154242 Mika Koivisto 2013-06-18T06:13:39Z 2013-06-18T06:13:39Z LPS-36007 SF Mika Koivisto 2013-06-18T06:13:39Z Revision 154241 Mika Koivisto 2013-06-18T06:13:38Z 2013-06-18T06:13:38Z LPS-35624 SF Mika Koivisto 2013-06-18T06:13:38Z Revision 154240 Mika Koivisto 2013-06-18T06:13:36Z 2013-06-18T06:13:36Z LPS-35624 Autogenerated Mika Koivisto 2013-06-18T06:13:36Z Revision 154239 Mika Koivisto 2013-06-18T06:13:34Z 2013-06-18T06:13:34Z LPS-35624 URLs should be generated to a page that contains a wiki portlet and if it's not found use the control panel to generate URLs Mika Koivisto 2013-06-18T06:13:34Z Revision 154238 Mika Koivisto 2013-06-18T06:13:33Z 2013-06-18T06:13:33Z LPS-35624 Replace manual building url to use PortletURL Mika Koivisto 2013-06-18T06:13:33Z Revision 154236 Mika Koivisto 2013-06-18T06:13:31Z 2013-06-18T06:13:31Z LPS-35624 Use portlet parameters instead of manually adding them to the url Mika Koivisto 2013-06-18T06:13:31Z Revision 154234 Mika Koivisto 2013-06-18T06:13:30Z 2013-06-18T06:13:30Z SF<br />Able to generate a p_p_auth token from PortletURLAction and to access to the portlets with add-default-resource enabled<br /><a href="http://svn.liferay.com/changelog/portal/?cs=154234"><img border="0" src="/social-coding-portlet/icons/svn.png" />SVN</a><br /><a href="http://issues.liferay.com/browse/LPS-34098"><img border="0" src="/social-coding-portlet/icons/jira.png" />JIRA</a> Mika Koivisto 2013-06-18T06:13:30Z Revision 154232 Mika Koivisto 2013-06-18T06:13:28Z 2013-06-18T06:13:28Z LPS-36383 Sort Mika Koivisto 2013-06-18T06:13:28Z Revision 154230 Mika Koivisto 2013-06-18T06:13:26Z 2013-06-18T06:13:26Z LPS-36383 Remove DoubleClickFilter Mika Koivisto 2013-06-18T06:13:26Z Revision 154227 Mika Koivisto 2013-06-18T06:13:17Z 2013-06-18T06:13:17Z LPS-36007 SF Mika Koivisto 2013-06-18T06:13:17Z Revision 154225 Mika Koivisto 2013-06-18T06:13:15Z 2013-06-18T06:13:15Z LPS-36007 When copying DDM structures and their templates, the templates are copied to the original structure and not the new one Mika Koivisto 2013-06-18T06:13:15Z Revision 154223 Mika Koivisto 2013-06-18T06:13:13Z 2013-06-18T06:13:13Z LPS-36376 Refactor SourceFormatter - initial commit Mika Koivisto 2013-06-18T06:13:13Z Revision 154221 Mika Koivisto 2013-06-18T06:13:11Z 2013-06-18T06:13:11Z LPS-36365 We should never be passing in null Mika Koivisto 2013-06-18T06:13:11Z Revision 154219 Mika Koivisto 2013-06-18T06:13:10Z 2013-06-18T06:13:10Z LPS-36365 Finder should convert fileEntryTypeKey to uppercase, since this is how we put it into the database Mika Koivisto 2013-06-18T06:13:10Z Revision 154217 Mika Koivisto 2013-06-18T06:13:08Z 2013-06-18T06:13:08Z LPS-36303 Missed one Mika Koivisto 2013-06-18T06:13:08Z Revision 154215 Mika Koivisto 2013-06-18T06:13:07Z 2013-06-18T06:13:07Z LPS-36303 Sort Mika Koivisto 2013-06-18T06:13:07Z Revision 154213 Mika Koivisto 2013-06-18T06:13:05Z 2013-06-18T06:13:05Z LPS-36303 Rename methods Mika Koivisto 2013-06-18T06:13:05Z Revision 154212 Mika Koivisto 2013-06-18T06:13:02Z 2013-06-18T06:13:02Z LPS-36303 Typos Mika Koivisto 2013-06-18T06:13:02Z Revision 154210 Mika Koivisto 2013-06-18T06:13:01Z 2013-06-18T06:13:01Z LPS-35872 SF Mika Koivisto 2013-06-18T06:13:01Z Revision 154208 Mika Koivisto 2013-06-18T06:12:59Z 2013-06-18T06:12:59Z LPS-35872 SF Mika Koivisto 2013-06-18T06:12:59Z Revision 154206 Mika Koivisto 2013-06-18T06:12:57Z 2013-06-18T06:12:57Z LPS-35872 Sometimes you called it LocalizedSite, sometimes you called it LocalizedURLSite.. so I just removed the URL part and assume that localizaiton in this class always deals with URLs Mika Koivisto 2013-06-18T06:12:57Z Revision 154204 Mika Koivisto 2013-06-18T06:12:56Z 2013-06-18T06:12:56Z LPS-35872 Test method for localized layout friendly urls Mika Koivisto 2013-06-18T06:12:56Z Revision 154202 Mika Koivisto 2013-06-18T06:12:55Z 2013-06-18T06:12:55Z LPS-36077 - CPPagetemplatesAcceptance.testcase - testsuite Mika Koivisto 2013-06-18T06:12:55Z Revision 154200 Mika Koivisto 2013-06-18T06:12:53Z 2013-06-18T06:12:53Z LPS-36077 - CPPagetemplatesAcceptance.testcase - testcase Mika Koivisto 2013-06-18T06:12:53Z Revision 154198 Mika Koivisto 2013-06-18T06:12:52Z 2013-06-18T06:12:52Z LPS-36077 - CPPagetemplatesAcceptance.testcase - macros Mika Koivisto 2013-06-18T06:12:52Z Revision 154196 Mika Koivisto 2013-06-18T06:12:50Z 2013-06-18T06:12:50Z LPS-36077 - CPPagetemplatesAcceptance.testcase - actions Mika Koivisto 2013-06-18T06:12:50Z Revision 154194 Mika Koivisto 2013-06-18T06:12:49Z 2013-06-18T06:12:49Z LPS-36077 - CPPagetemplatesAcceptance.testcase - paths Mika Koivisto 2013-06-18T06:12:49Z Revision 154192 Mika Koivisto 2013-06-18T06:12:46Z 2013-06-18T06:12:46Z LPS-35924 Lang keys Mika Koivisto 2013-06-18T06:12:46Z Revision 154189 Mika Koivisto 2013-06-18T06:12:43Z 2013-06-18T06:12:43Z LPS-35924 SF Mika Koivisto 2013-06-18T06:12:43Z Revision 154187 Mika Koivisto 2013-06-18T06:12:42Z 2013-06-18T06:12:42Z LPS-35924 Encapsulate the retrieval of the categories map and the storage in the request within PortalImpl And added benefit is that the portlet can now be invoked from anywhere and not only from within control_panel.jsp I considered breaking down ACCESS_IN_CONTROL_PANEL into three different actions, but ended up discarding it because for the backend it's still all the Control Panel, its just in the UI that the user does not realize it and thinks that he is in Site Administration or My Account, so I concluded that a solution that only affects the UI would be best. Mika Koivisto 2013-06-18T06:12:42Z Revision 154185 Mika Koivisto 2013-06-18T06:12:40Z 2013-06-18T06:12:40Z LPS-35924 isControlPanelPortlet should also consider that the category might be the SITES_ADMINISTRATION prefix Mika Koivisto 2013-06-18T06:12:40Z Revision 154182 Mika Koivisto 2013-06-18T06:12:36Z 2013-06-18T06:12:36Z Lang keys Mika Koivisto 2013-06-18T06:12:36Z Revision 154180 Mika Koivisto 2013-06-18T06:12:34Z 2013-06-18T06:12:34Z LPS-36279 SF Mika Koivisto 2013-06-18T06:12:34Z Revision 154178 Mika Koivisto 2013-06-18T06:12:32Z 2013-06-18T06:12:32Z LPS-36279 Make sure the site selector is always shown as a menu Mika Koivisto 2013-06-18T06:12:32Z Revision 154176 Mika Koivisto 2013-06-18T06:12:31Z 2013-06-18T06:12:31Z LPS-36279 When a user only has access to one portlet within Site Administrator hide the left menu Mika Koivisto 2013-06-18T06:12:31Z Revision 154174 Mika Koivisto 2013-06-18T06:12:30Z 2013-06-18T06:12:30Z LPS-36279 Remove logic that is no longer necessary because it's already done in the Java logic Mika Koivisto 2013-06-18T06:12:30Z Revision 154172 Mika Koivisto 2013-06-18T06:12:28Z 2013-06-18T06:12:28Z LPS-36279 Refactor JSP to use the new method Mika Koivisto 2013-06-18T06:12:28Z Revision 154170 Mika Koivisto 2013-06-18T06:12:26Z 2013-06-18T06:12:26Z LPS-36279 Add method getSiteAdministrationCategoriesMap Mika Koivisto 2013-06-18T06:12:26Z Revision 154167 Mika Koivisto 2013-06-18T06:12:24Z 2013-06-18T06:12:24Z LPS-36279 Order method Mika Koivisto 2013-06-18T06:12:24Z Revision 154165 Mika Koivisto 2013-06-18T06:12:22Z 2013-06-18T06:12:22Z LPS-36279 Refactor getControlPanelCategoriesMap to allow reusing the implementation I left the new protected method in the wrong order to facilitate doing a diff. Will reorder in the next commit. Mika Koivisto 2013-06-18T06:12:22Z Revision 154164 Mika Koivisto 2013-06-18T06:12:20Z 2013-06-18T06:12:20Z Test Fixes - paths Mika Koivisto 2013-06-18T06:12:20Z Revision 154163 Mika Koivisto 2013-06-18T06:12:18Z 2013-06-18T06:12:18Z LPS-36374 Mika Koivisto 2013-06-18T06:12:18Z Revision 154162 Mika Koivisto 2013-06-18T06:12:16Z 2013-06-18T06:12:16Z LPS-36032 Sort Mika Koivisto 2013-06-18T06:12:16Z Revision 154161 Mika Koivisto 2013-06-18T06:12:15Z 2013-06-18T06:12:15Z LPS-36032 I think it's OK to use "type" and "key" since it's the context is only within this class Mika Koivisto 2013-06-18T06:12:15Z Revision 154160 Mika Koivisto 2013-06-18T06:12:13Z 2013-06-18T06:12:13Z LPS-36032 Use the right word Mika Koivisto 2013-06-18T06:12:13Z Revision 154159 Mika Koivisto 2013-06-18T06:12:12Z 2013-06-18T06:12:12Z LPS-36032 Use correct var name Mika Koivisto 2013-06-18T06:12:12Z