留言板

Patch for 6.1.1 GA2 solving many issues

thumbnail
Juan Gonzalez P,修改在11 年前。

Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Hi community,

As I've been doing some years ago, I've released a patch for solving many issues for 6.1.1 GA2. I've tried to patch only bugs, not improvements.

For patching just unzip the .diff file into liferay 6.1.1 source folder (same folder level as portal-impl, portal-web, etc folders) and use patch command in Linux or other tools for Windows. After that just compile and enjoy!

Example on how to apply patch in Linux: patch -p0 < patch_6.1.1_juan.diff

This patch solves this issues:

SECURITY/PERMISSIONS

LPS-30122 Able to delete any User
LPS-29054 - CLONE - A user with inherited private pages from a user group cannot access the pages
LPS-29208 JournalArticle permissions are not published for roles which permissions were removed
LPS-29008 Users with owner or non-portal administrator roles are allowed to reset omniadmin/default user password and settings
LPS-29379 Several permission checks don't account for customizable or virtual layouts
LPS-29476 Search portlet results are displaying for guest even without guest view permissions. (Web Content / Journal) -> Important issue where private web contents where showed in search result lists.
LPS-29597 members without permissions are able to access private pages
LPS-29743 Users can still view portlet in private pages even through view permission is unchecked
LPS-29516 Rollback LPS-26318 (Web Content Display portlet is not visible to guest even with guest view permission)
LPS-29505 When using search, content scoped to groups may not be handled properly
LPS-30418 Add dynamic inheritance check to getFileEntries().
LPS-30518 Apply same check as DLStoreImpl#getFile
LPS-30015 guest can's search the bookmark which permission is "Viewable by Anyone(Guest Role)
LPS-30437 Users without permission can create folders/files in the root folder
LPS-30188 In default, site member can be able to add documents in home directory of document and media portlet

BROWSER/JAVASCRIPT

LPS-29041 Path doesn't return with correct protocol -> Critical issue for users who use load balancer using ssl only.
LPS-29154 Control Panel theme breaks CKeditor dialog in IE8
LPS-29594 Poll Display portlet does not show correctly the bars when showing the poll's result
LPS-28924 - Editing a Subcategory converts it from child to sibling
LPS-29645 Unable to download a document in IE8 with SSL -> Without this patch, you couldn't download documents and show inline (PDF) in IE if using SSL only.
LPS-30181 WebServerServlet URLs do not correctly set the content length on HTTP headers for non-image files

TEMPLATES/STAGING

LPS-28813 The article's default template isn't published to remote live
LPS-28977 - Temp file not being deleted after LAR import through hook
LPS-29072 ArticleUrlTitle may change when publishing to live
LPS-29072 Keep the urlTitle when updating
LPS-29370 Wrong Page Template export with some porlet
LPS-29449 Delete Missing Pages option during Publish deletes all live pages except the selected pages
LPS-29474 Pages created w/Templates that include Documents and Media Portlet w/Global Scope creates local copy of Doc & Media
LPS-29629 Fix deleteMissingLayouts when there is no staging group
LPS-29495 Journal article export/import does't work properly when last revision is expired
LPS-28995 Disable non "site pages variations" pages in selection list of the pop up Publish to Live
LPS-29021 If a portlet is staged, this should be checked by default in publish to live
LPS-28147 Portlet permissions removed when resetting site to site template


DOCUMENTS & MEDIA/WEBDAV

LPS-28094 - Document Library: Moving documents between folders results in error accessing file
LPS-29108 WebDav in Windows XP seemed broken in 6.1. This patch solves all those issues. -> Important issue for WebDav + XP users
LPS-29320 Document & Media Portlet Search returns inconsistent results
LPS-29105 Documents and Media Document Types and Metadata Sets does not show the right number of results
LPS-29786 Unable to upload a file with valid extension using multiple uploader after setting "Allowed File Extensions" in control panel
LPS-29678 Getting Content Stream should get the latest version
LPS-29574 If image/document already exist, Upload Image/Document From Web Content Portlet Issue will throw errors in log but and not display "image/document already exists or image already uploaded"
LPS-25911 WebDAV URL will have "null" as context path for the company group
LPS-30621 move folders and documents fail in unix or linux platform when crossing file system
LPS-29928 Editing documents through WebDAV resets Custom Field values and Categories for document

PLUGINS

LPS-29000 DestinationEventListener now removed on plugin undeployment
LPS-29103 Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)


PERFORMANCE/STABILITY

LPS-29268 Simple DOS attack on PortletPreferences
LPS-29323 Long load time when accessing files with links like '/c/document_library/get_file
LPS-29406 Images in blog, wiki or message board render slowly in Internet explorer 7 and 8
LPS-29508 Small memory optimization for PermissionCheckerBagImpl instances
LPS-29031 Finder Cache is not properly invalidated in a cluster environment
LPS-30243 clear resources so portal can be restarted in app servers (weblogic)

UPGRADE

LPS-29479 Non-Liferay tables upgraded on Oracle -> important issue for Oracle users.
LPS-29349 Startup exception when en_US not present
LPS-29879 Verify corrupt layout data


LDAP

LPS-29100 Several user fields are reset after LDAP import
LPS-29003 Wrong documentation in LPS-28639, must manually set java system properties instead of relying on system.properties file
LPS-30121 Defined LDAP values are overriden by database values after configuration


MISC.

LPS-28949 FriendlyURL to non-existing web content does not redirect correctly
LPS-29086 Search Portlet 'Return to Full Page' Inconsistent
LPS-29057 Asset Publisher - "Does not Contain" Filter not working
LPS-29324 Inconsistent behavior encountered with 'AssetTagServiceUtil' search method when logging in as 'Power User' vs 'Admin' user
LPS-29216 Internal Server Error in Wiki, with "Select Page" scope
LPS-29378 File Attachments Are Being Deleted When Dynamic Data Lists Records are Deleted
LPS-29202 /c/journal/get_articles search on structureId doesn't return any articles even when there are correct articles present
LPS-29360 Related Assets Portlet does not work when global or multiple scopes(groups) are selected in Asset Publisher
LPS-29572 Related assets for wikis does not correct count the number of pages
LPS-29668 Fixing void return type function calls' UnsupportedOperationException throwing.
LPS-29626 Mime type detection closes stream during import
LPS-29405 Double indexing of web content overwrites version with oldest version
LPS-30058 NPE when viewing a page with a portlet scoped to a layout that doesn't exist
LPS-29715 Sitemap.xml date is not valid ISO8601 date
LPS-30524 Using Virtual Hosts when editing a web content in the AP makes you authenticate again
LPS-29716 Fix sitemap.xml for portal instances
LPS-29523 Arguments for JSON actions does not have fail back deserilization
LPS-29781 Unable to save categories when adding or updating users
LPS-27624 Being a member of an Organization with no Pages will reduce the number of drop-down items in Go To
LPS-29845 jsonws ctx root
LPS-29904 Regression issue with portal-ext.properties loading order (order should be reversed)
LPS-30185 Can not send email to mutilple recipients
LPS-30026 SecureFilter fails to populate companyId basic auth requests for a particular session

EDIT: added simple categories for summarize issues.
EDIT 2012-10-30. Added issues:

LPS-30188 In default, site member can be able to add documents in home directory of document and media portlet
LPS-30026 SecureFilter fails to populate companyId basic auth requests for a particular session
LPS-30185 Can not send email to mutilple recipients
LPS-29904 Regression issue with portal-ext.properties loading order (order should be reversed)
LPS-29845 jsonws ctx root
LPS-30181 WebServerServlet URLs do not correctly set the content length on HTTP headers for non-image files
LPS-27624 Being a member of an Organization with no Pages will reduce the number of drop-down items in Go To
LPS-30121 Defined LDAP values are overriden by database values after configuration
LPS-29781 Unable to save categories when adding or updating users
LPS-29928 Editing documents through WebDAV resets Custom Field values and Categories for document
LPS-30437 Users without permission can create folders/files in the root folder
LPS-29523 Arguments for JSON actions does not have fail back deserilization
LPS-29103 Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)
LPS-30015 guest can's search the bookmark which permission is "Viewable by Anyone(Guest Role)
LPS-29716 Fix sitemap.xml for portal instances
LPS-30418 Add dynamic inheritance check to getFileEntries().
LPS-30518 Apply same check as DLStoreImpl#getFile
LPS-30524 Using Virtual Hosts when editing a web content in the AP makes you authenticate again
LPS-30243 clear resources so portal can be restarted in app servers (weblogic)
LPS-29715 Sitemap.xml date is not valid ISO8601 date
LPS-30621 move folders and documents fail in unix or linux platform when crossing file system
thumbnail
Sampsa Sohlman,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 230 加入日期: 07-9-27 最近的帖子
Wow Juan, that includes 60 fixes !

Eres un Liferay emoticon

How many of these you made your self?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
What do you mean by "made myself"? These patches come from github, but I had to do slightly changes because some of them changed other behaviour.
thumbnail
Sampsa Sohlman,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 230 加入日期: 07-9-27 最近的帖子
I was only wondering how big work was that since fix amount is huge.

Thanks again.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Well, it required some minutes in a daily basis (many hours in total) because I had to follow issues, watch how to solve them properly, watch all necessary changes, etc. So this work started in 1th August, when 6.1.1 was out.

Of course had to see all the relations between issues too, because some of them caused regressions on another issues.

Fortunately at this point I see is stable enough to publish it.

In fact I used this in our production upgrade from 6.0.5 to 6.1.1 GA2 and was 100% successful and stable.
thumbnail
Gabriel Leon Leyva,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 243 加入日期: 09-6-20 最近的帖子
Could you show us the steps for applying the patches for a non expert like us, that loves liferay, downloaded the source code and tests knew things. :=)

I have the 6.1.1 GA2 ubuntu 12.04 tomcat 7.0.27 java sun jre 6.0.35

thanks in advance.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Edited first post. If you are using Linux, after unzip then execute patch -p0 < patch.diff
thumbnail
Gabriel Leon Leyva,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 243 加入日期: 09-6-20 最近的帖子
thanks :=)
thumbnail
Ákos Gábriel,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 33 加入日期: 09-10-5 最近的帖子
Great job, thank you!

If you're interested I can offer you a continuous integration environment (based on Jenkins) where a lot of repetitive tasks can be automated.

Akos
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Thanks for your help, Akos.
Linus Sphinx,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 99 加入日期: 10-8-12 最近的帖子
Juan Gonzalez P:

In fact I used this in our production upgrade from 6.0.5 to 6.1.1 GA2 and was 100% successful and stable.

Best news I've heard in a while. Thanks
thumbnail
Luis Mas,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 146 加入日期: 09-5-18 最近的帖子
Great Juan!!!

Eres grande!!! Te hacemos la ola!!!

Enhorabuena y gracias!!!
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Gracias, Luis. Espero que te sirva :-D
thumbnail
Gabriel Leon Leyva,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 243 加入日期: 09-6-20 最近的帖子
compilado y trabajando al 100% gracias Juan, Saludos desde Sonora México.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Gracias Gabriel,

Glad it worked for you emoticon
thumbnail
Mika Koivisto,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 1519 加入日期: 06-8-7 最近的帖子
Nice work Juan. Have you by any change published your branch in Github?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Thanks Mika,

Ups, I didn't. I have all this commits in our SVN separate by LPS, perhaps should have to migrate to github too.

BTW, in this thread

http://www.liferay.com/community/forums/-/message_boards/message/16708189

we are talking about making all of these patches available to community.
Sergio Ramazzina,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 6 加入日期: 11-6-8 最近的帖子
Thanks Juan for your work!

Sergio
thumbnail
Miguel Ángel Júlvez,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 63 加入日期: 11-3-29 最近的帖子
Como siempre Juan... ¡¡te sales del gráfico tio!!

Un millón de gracias
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
De nada Miguel ;)

Hope you'll post here how it goes for you...
thumbnail
Rafael Lluis,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 30 加入日期: 12-10-15 最近的帖子
Muchas Gracias Juan. Bueno, yo estoy usando la versión publicada en https://www.lcepatchers.org/. Entiendo que es más o menos lo mismo. Desde luego a mí me está funcionando genial.

Gracias de nuevo
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Hi Rafael,

Yes, in fact all the work is being done there instead of here...I pushed some commits yesterday.
thumbnail
Gabriel Leon Leyva,修改在10 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 243 加入日期: 09-6-20 最近的帖子
Good morning Juan, I have a problem with assets publisher, I had a blog page but for making easier remove blog portlet and replace it with asset publisher, but on normal user no matter what permission I configure the asset publisher does not display the "Add Blog" button. Is this a bug how Can I Patch it? (I have the last version of liferay patched) of your site.

In the normal blog portlet they have permission to add a blog entry

Found the problem (edit control must be checked) in order to see the add new button it's there a work around?

I if edit control is checked users can delete portlets

Thanks :-)
thumbnail
Juan Gonzalez,修改在10 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Sorry Gabriel, in this case seems that same permissions is used for both actions.

Perhaps you can search if there's an issue like that in JIRA.
thumbnail
James Falkner,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 1399 加入日期: 10-9-17 最近的帖子
Juan! This is really helpful, thanks for doing this! You provide a nice in-between-GA service for our community. My hope is that we can cut GA releases more frequently in the future, and lessen your workload emoticon

Now you should hook up with Aad and Co. and get some builds going!
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Thanks James. This is one of the advantages of having open source and everything in github.

Who is Aad?
thumbnail
James Falkner,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 1399 加入日期: 10-9-17 最近的帖子
Juan Gonzalez P:
Thanks James. This is one of the advantages of having open source and everything in github.

Who is Aad?


Yep, open source is great! What's even better is your willingness to volunteer your time to help everyone out emoticon So thanks again for that!

Aad Nales started the effort over here in this thread emoticon
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Ok James, I am aware of that thread.

Thanks.
Karla Williams,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 2 加入日期: 12-8-17 最近的帖子
Juan, is this just for CE? Is there any way to obtain the path for EE? or EE Trial?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Hi Karia,

Nope, this is for CE (6.1.1 GA2).

BTW, why you need for EE? Having that license you should get patches from Liferay.
Karla Williams,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 2 加入日期: 12-8-17 最近的帖子
Still prototyping using the Trial version of EE
thumbnail
Alain Dresse,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 95 加入日期: 11-7-18 最近的帖子
Many thanks Juan !
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Another patch version with more solved issues in next days.

Stay tuned! emoticon
thumbnail
Ivano Carrara,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Expert 帖子: 345 加入日期: 05-7-3 最近的帖子
Hi Juan,

Thank you for your valuable work !!

Yesterday I posted a new thread with title "Kaleo Error retrieving tasks after migration from 6.0.6 to 6.1.1 CE GA2" that you can find here:
http://www.liferay.com/community/forums/-/message_boards/message/17021394

Please, could you contact me for a private question ?
If yes, write me to icarrara@studio5.it

Thank you in advance !
Ivano C.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Ivano,

I've accepted your friend request. Guess now you can contact me with private message...
thumbnail
Ivano Carrara,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Expert 帖子: 345 加入日期: 05-7-3 最近的帖子
Hi Juan,

I can't see your email address on your profile page, so I wrote on your wall...

Thank you !

Ivano C.
thumbnail
Luis Mas,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 146 加入日期: 09-5-18 最近的帖子
Juan Gonzalez P:
Another patch version with more solved issues in next days.

Stay tuned! emoticon


WOW, you alone is the Community Patcher!
thumbnail
Troy Griffitts,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 18 加入日期: 11-8-6 最近的帖子
Juan,

Thank you so much for all that you do. We've been wanting to upgrade to GA2 but cannot because of a regression.

We currently use the Liferay javascript API, which in turn uses the jsonws API, to create forum posts, and GA2 shipped with a bug that would not allow the jsonws call to succeed. This patch fixed the problem for us. If you might be so kind as to include it in your next patch bundle, we would be so appreciative. Thank you for considering.

http://issues.liferay.com/browse/LPS-29523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Ok Troy, added to my issues list for next patch.
thumbnail
Ivano Carrara,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Expert 帖子: 345 加入日期: 05-7-3 最近的帖子
Hi Juan,

I would like to submit to your attention this issue: Custom Spring MVC -portlets broken after upgrading to Liferay 6.1 GA2 (web.xml listener order)
You can find the issue here: http://issues.liferay.com/browse/LPS-29103

In fact, in presence of complex plugins that contains shared beans (service layer, dao layer and such), after you deployed it you have to manually swap the position of some listeners definition in web.xml file.

The patch it is here: https://github.com/vpugar/liferay-portal/blob/6.1.x_LPS-29103/portal-impl/src/com/liferay/portal/tools/deploy/BaseDeployer.java
Without the above patch, the deploy of your plugin fails.

Thank you for your attention !

Ivano C.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Ivano,

Yep that issue was in my issues list already, but didn't patch (probably because I didn't really need it).

Will be in next patch emoticon
Timmy M.,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 34 加入日期: 10-3-2 最近的帖子
It would be great if we could make these patches available in a library or (ext) plugin?
thumbnail
Chris Huff,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 25 加入日期: 11-4-14 最近的帖子
Juan,

I applied the patch in Linux on the contents of the sourceforge downoload "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip" and got a bunch of hunk rejects. (some did execute, but lots of rej files generated). Am I supposed to use the 6.1.x branch from svn, or the zip file (above) from sourceforge?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Please, post the steps you did (and directories where you did them) . It should work.
thumbnail
Chris H,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 25 加入日期: 11-4-14 最近的帖子
Juan,

Steps:
- Unzip sourceforce source package "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip"
- place diff file "patch_6.1.1_juan.diff" in "liferay-portal-src-6.1.1-ce-ga2" folder
> cd liferay-portal-src-6.1.1-ce-ga2
> patch -p0 < patch_6.1.1_juan.diff

Resulted in >60% hunk rejects.

UPDATE:

I used the latest SVN checkout of 6.1.x Branch and had no hunk errors! Success.
So be sure to pass it on that the 6.1.1 source from Sourceforge is not working with the patch for some reason.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Great Chris,

It should be same source, but seems it isn't :-D. Very strange that >60% resulted in failed rejects anyway.
thumbnail
Luis Mas,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 146 加入日期: 09-5-18 最近的帖子
Chris H:
Juan,

Steps:
- Unzip sourceforce source package "liferay-portal-src-6.1.1-ce-ga2-20120731132656558.zip"
- place diff file "patch_6.1.1_juan.diff" in "liferay-portal-src-6.1.1-ce-ga2" folder
> cd liferay-portal-src-6.1.1-ce-ga2
> patch -p0 < patch_6.1.1_juan.diff

Resulted in >60% hunk rejects.

UPDATE:

I used the latest SVN checkout of 6.1.x Branch and had no hunk errors! Success.
So be sure to pass it on that the 6.1.1 source from Sourceforge is not working with the patch for some reason.


I've read in some place that Sourceforge source has something with windows chars and you have to pass a sentence before [(in the security team forum):

"It is recommended that you download the source from Github (from here). If you have downloaded the source code from SourceForge.net, be aware that SourceForge code sometimes contains Windows-style line endings, and you may need to first convert them to unix-style line endings using something like:

cd $LIFERAY_SRC_HOME; find . -type f -exec dos2unix {} \;"




maybe is because of that?
thumbnail
Chris H,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Junior Member 帖子: 25 加入日期: 11-4-14 最近的帖子
That's what I thought, but then I considered that about 40% of the hunks were processed properly, so I suppose if that were the problem then it would reject all patches and not some :-)
thumbnail
Hitoshi Ozawa,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 7942 加入日期: 10-3-24 最近的帖子
It has to do with the CR LF at the end of a row. Unfortunately, liferay source code didn't standardize on this so there are some code with CR+LF and some with just LF. That's why some are processed properly while other are not.
thumbnail
Sampsa Sohlman,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Regular Member 帖子: 230 加入日期: 07-9-27 最近的帖子
I have to say thanks again.

This patch did solve some serious issues on the social office installation that I made. Like moving the document library article and then missing link.
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
Happy to hear that. Thanks for telling!

I have almost finished my next patch with some other issues (some of them were requested by users in this forum thread).
K Boyce,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 17 加入日期: 07-6-3 最近的帖子
Hey.. this is awesome. Any eta on LPS-29103 being included?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
After being in Liferay Spain Symposium and taking some days for rest, probably will have ready by the end of week (thursday, friday...).

That isssue is already in patch but wanted to include 2 additional LPS.
K Boyce,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

New Member 帖子: 17 加入日期: 07-6-3 最近的帖子
It's in the patch on this post already? Also is there any possibility of a binary patch?
thumbnail
Juan Gonzalez P,修改在11 年前。

RE: Patch for 6.1.1 GA2 solving many issues

Liferay Legend 帖子: 3089 加入日期: 08-10-28 最近的帖子
K Boyce:
Also is there any possibility of a binary patch?


What do you mean by "binary patch"? You can compile for any server you want. You can search in liferay.com wiki or user guide to know how to...