Thanks Andew for a quick reply! 
Overriding the struts action as per Portlet Struts Action hook may not work.
I think, cases other than ADD may not get executed correctly since we do something like this in the processAction method
The Window state and any sort of redirection is not handled cleanly if we do this (or shall I say I am not aware how it needs to be done cleanly.)
Please correct me if I am wrong on this.
Can you let me know if we can put this check in a service hook of DLAppService?
Thanks,
Mansi
Andew Jardine:
Ned you would need to create a Portlet Struts Action hook for the action path /document_library/edit_file_entry and override the com.liferay.portlet.documentlibrary.action.EditFileEntryAction (I think). In there yoou would basically check the folder expando values and compare the "allowed extensions" with the file provided if the CMD value is ADD. If someone is trying to add a bad value then you short circuit and return.
If you want to make it extra pretty, you can include an error message (SessionErrors.add(...)) and then hook the JSP to make sure that you error message is provided to the user.
Overriding the struts action as per Portlet Struts Action hook may not work.
I think, cases other than ADD may not get executed correctly since we do something like this in the processAction method
public void processAction(
StrutsPortletAction originalStrutsPortletAction,
PortletConfig portletConfig, ActionRequest actionRequest,
ActionResponse actionResponse)
throws Exception {
ThemeDisplay themeDisplay =
(ThemeDisplay)actionRequest.getAttribute(WebKeys.THEME_DISPLAY);
String cmd = ParamUtil.getString(actionRequest, Constants.CMD);
try{
if (cmd.equals(Constants.ADD)) {
//Code to check the uploaded file extension is allowed to be added to this folder.
}
originalStrutsPortletAction.processAction(
originalStrutsPortletAction, portletConfig, actionRequest,
actionResponse);
}
The Window state and any sort of redirection is not handled cleanly if we do this (or shall I say I am not aware how it needs to be done cleanly.)
Please correct me if I am wrong on this.
Can you let me know if we can put this check in a service hook of DLAppService?
Thanks,
Mansi
Hey Andew, I did try this approach of custom fields using hook for service and it does solve my problem. But I can try the Action class changes also and based on that decide which approach I would take.
Thanks once again for your prompt reply.
Thanks once again for your prompt reply.
Hi Mansi,
Glad to hear that you got it working. The only difference I can think of top of mind, between the service override and the struts action override is how quickly the condition is checked. The action fires first so the check ocurring in there means you don't need to go as far down the execution path before detecting the error condition and returning. Honestly, I doubt that matters -- and if you wantd to be that picky about it then you could probably also argue that usin gthe struts action hook render method to retrieve the custom attributes and send them into the JSP .. and then use a JSP hook with some custom javascript to validate the fields before the submit even happens would be the best preventative measure.
As I said though, at this stage it'd be turning into more of a technical debate. A problem solved is a problem solved. Thanks for sharing!
Glad to hear that you got it working. The only difference I can think of top of mind, between the service override and the struts action override is how quickly the condition is checked. The action fires first so the check ocurring in there means you don't need to go as far down the execution path before detecting the error condition and returning. Honestly, I doubt that matters
-- and if you wantd to be that picky about it then you could probably also argue that usin gthe struts action hook render method to retrieve the custom attributes and send them into the JSP .. and then use a JSP hook with some custom javascript to validate the fields before the submit even happens would be the best preventative measure. As I said though, at this stage it'd be turning into more of a technical debate. A problem solved is a problem solved. Thanks for sharing!
